components/history/core/browser/history_backend_db_unittest.cc - Issue 2053913002: Remove MessageLoop::current()->RunUntilIdle() in components.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/history/core/browser/history_backend_db_unittest.cc

Issue 2053913002: Remove MessageLoop::current()->RunUntilIdle() in components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/history/core/browser/expire_history_backend_unittest.cc ('k') | components/omnibox/browser/shortcuts_provider_test_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/history/core/browser/history_backend_db_unittest.cc

diff --git a/components/history/core/browser/history_backend_db_unittest.cc b/components/history/core/browser/history_backend_db_unittest.cc

index bab0f87d1dec9b24a824d55bcdadc00922c211f7..fd033d7f8a2f867938a5b93dfc0bea2c8b864961 100644

--- a/components/history/core/browser/history_backend_db_unittest.cc

+++ b/components/history/core/browser/history_backend_db_unittest.cc

@@ -26,6 +26,7 @@

#include "base/format_macros.h"

#include "base/guid.h"

+#include "base/run_loop.h"

#include "base/strings/string_util.h"

#include "base/strings/stringprintf.h"

#include "base/strings/utf_string_conversions.h"

@@ -982,7 +983,7 @@ TEST_F(HistoryBackendDBTest, ConfirmDownloadInProgressCleanup) {

// Allow the update to propagate, shut down the DB, and confirm that

// the query updated the on disk database as well.

- base::MessageLoop::current()->RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

DeleteBackend();

{

sql::Connection db;