components/omnibox/browser/shortcuts_provider_test_util.cc - Issue 2053913002: Remove MessageLoop::current()->RunUntilIdle() in components.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/omnibox/browser/shortcuts_provider_test_util.cc

Issue 2053913002: Remove MessageLoop::current()->RunUntilIdle() in components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/history/core/browser/history_backend_db_unittest.cc ('k') | components/password_manager/core/browser/password_store_default_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/omnibox/browser/shortcuts_provider_test_util.cc

diff --git a/components/omnibox/browser/shortcuts_provider_test_util.cc b/components/omnibox/browser/shortcuts_provider_test_util.cc

index 59022bdcaaa658a438eef9dbeee31da42c30f0b1..71eedd8b2448d61659fc5eb7dec697675c7a41c1 100644

--- a/components/omnibox/browser/shortcuts_provider_test_util.cc

+++ b/components/omnibox/browser/shortcuts_provider_test_util.cc

@@ -4,7 +4,7 @@

#include "components/omnibox/browser/shortcuts_provider_test_util.h"

-#include "base/message_loop/message_loop.h"

+#include "base/run_loop.h"

#include "base/strings/utf_string_conversions.h"

#include "components/omnibox/browser/autocomplete_match.h"

#include "components/omnibox/browser/shortcuts_backend.h"

@@ -70,7 +70,7 @@ void RunShortcutsProviderTest(

const std::vector<ExpectedURLAndAllowedToBeDefault>& expected_urls,

std::string expected_top_result,

base::string16 top_result_inline_autocompletion) {

- base::MessageLoop::current()->RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

AutocompleteInput input(text, base::string16::npos, std::string(), GURL(),

metrics::OmniboxEventProto::INVALID_SPEC,

prevent_inline_autocomplete, false, true, true, false,