components/sync_driver/frontend_data_type_controller_unittest.cc - Issue 2053913002: Remove MessageLoop::current()->RunUntilIdle() in components.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync_driver/frontend_data_type_controller_unittest.cc

Issue 2053913002: Remove MessageLoop::current()->RunUntilIdle() in components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/sync_bookmarks/bookmark_data_type_controller_unittest.cc ('k') | components/sync_driver/non_ui_data_type_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sync_driver/frontend_data_type_controller_unittest.cc

diff --git a/components/sync_driver/frontend_data_type_controller_unittest.cc b/components/sync_driver/frontend_data_type_controller_unittest.cc

index 03c47bdb8d4abe39f09d5ff7be246b53ebb414c1..a64ccc86319016d686cbe0ed210bcae763e11005 100644

--- a/components/sync_driver/frontend_data_type_controller_unittest.cc

+++ b/components/sync_driver/frontend_data_type_controller_unittest.cc

@@ -11,6 +11,7 @@

#include "base/callback.h"

#include "base/location.h"

#include "base/message_loop/message_loop.h"

+#include "base/run_loop.h"

#include "base/single_thread_task_runner.h"

#include "base/threading/thread_task_runner_handle.h"

#include "base/tracked_objects.h"

@@ -149,7 +150,7 @@ class SyncFrontendDataTypeControllerTest : public testing::Test,

PumpLoop();

}

- void PumpLoop() { base::MessageLoop::current()->RunUntilIdle(); }

+ void PumpLoop() { base::RunLoop().RunUntilIdle(); }

base::MessageLoop message_loop_;

scoped_refptr<FrontendDataTypeControllerFake> frontend_dtc_;