Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Unified Diff: components/browser_sync/browser/profile_sync_service_bookmark_unittest.cc

Issue 2053913002: Remove MessageLoop::current()->RunUntilIdle() in components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/browsing_data_ui/history_notice_utils_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/browser_sync/browser/profile_sync_service_bookmark_unittest.cc
diff --git a/components/browser_sync/browser/profile_sync_service_bookmark_unittest.cc b/components/browser_sync/browser/profile_sync_service_bookmark_unittest.cc
index d91c577030933d453621eabc5fd270e2c229ac82..91d18cf44702992ac87689bac4347a4a1288cea8 100644
--- a/components/browser_sync/browser/profile_sync_service_bookmark_unittest.cc
+++ b/components/browser_sync/browser/profile_sync_service_bookmark_unittest.cc
@@ -467,7 +467,7 @@ class ProfileSyncServiceBookmarkTest : public testing::Test {
// This noticeably speeds up the unit tests that request it.
if (save == DONT_SAVE_TO_STORAGE)
model_->ClearStore();
- base::MessageLoop::current()->RunUntilIdle();
+ base::RunLoop().RunUntilIdle();
}
int GetSyncBookmarkCount() {
@@ -2446,7 +2446,7 @@ TEST_F(ProfileSyncServiceBookmarkTestWithData, UpdateTransactionVersion) {
LoadBookmarkModel(DELETE_EXISTING_STORAGE, DONT_SAVE_TO_STORAGE);
StartSync();
WriteTestDataToBookmarkModel();
- base::MessageLoop::current()->RunUntilIdle();
+ base::RunLoop().RunUntilIdle();
BookmarkNodeVersionMap initial_versions;
@@ -2471,7 +2471,7 @@ TEST_F(ProfileSyncServiceBookmarkTestWithData, UpdateTransactionVersion) {
// the same.
const BookmarkNode* bookmark_bar = model()->bookmark_bar_node();
model()->Remove(bookmark_bar->GetChild(0));
- base::MessageLoop::current()->RunUntilIdle();
+ base::RunLoop().RunUntilIdle();
BookmarkNodeVersionMap new_versions;
GetTransactionVersions(model()->root_node(), &new_versions);
EXPECT_EQ(initial_versions[model()->root_node()->id()] + 1,
@@ -2485,7 +2485,7 @@ TEST_F(ProfileSyncServiceBookmarkTestWithData, UpdateTransactionVersion) {
const BookmarkNode* changed_bookmark =
model()->bookmark_bar_node()->GetChild(0);
model()->SetTitle(changed_bookmark, base::ASCIIToUTF16("test"));
- base::MessageLoop::current()->RunUntilIdle();
+ base::RunLoop().RunUntilIdle();
GetTransactionVersions(model()->root_node(), &new_versions);
EXPECT_EQ(initial_versions[model()->root_node()->id()] + 2,
new_versions[model()->root_node()->id()]);
@@ -2503,7 +2503,7 @@ TEST_F(ProfileSyncServiceBookmarkTestWithData, PersistenceError) {
LoadBookmarkModel(DELETE_EXISTING_STORAGE, DONT_SAVE_TO_STORAGE);
StartSync();
WriteTestDataToBookmarkModel();
- base::MessageLoop::current()->RunUntilIdle();
+ base::RunLoop().RunUntilIdle();
BookmarkNodeVersionMap initial_versions;
« no previous file with comments | « no previous file | components/browsing_data_ui/history_notice_utils_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698