components/data_usage/core/data_use_aggregator_unittest.cc - Issue 2053913002: Remove MessageLoop::current()->RunUntilIdle() in components.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_usage/core/data_use_aggregator_unittest.cc

Issue 2053913002: Remove MessageLoop::current()->RunUntilIdle() in components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc ('k') | components/dom_distiller/core/distilled_content_store_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_usage/core/data_use_aggregator_unittest.cc

diff --git a/components/data_usage/core/data_use_aggregator_unittest.cc b/components/data_usage/core/data_use_aggregator_unittest.cc

index 801a96b366965548916ad513cfa640fa617a9535..e3d121f2bc4fc8816328fdc2688681524ea6afae 100644

--- a/components/data_usage/core/data_use_aggregator_unittest.cc

+++ b/components/data_usage/core/data_use_aggregator_unittest.cc

@@ -16,6 +16,7 @@

#include "base/callback.h"

#include "base/macros.h"

#include "base/message_loop/message_loop.h"

+#include "base/run_loop.h"

#include "base/time/time.h"

#include "components/data_usage/core/data_use.h"

#include "components/data_usage/core/data_use_amortizer.h"

@@ -422,7 +423,7 @@ TEST_F(DataUseAggregatorTest, ReportOffTheRecordDataUse) {

// Off the record data use should not be reported to observers.

data_use_aggregator()->ReportOffTheRecordDataUse(1000, 1000);

- base::MessageLoop::current()->RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

EXPECT_EQ(static_cast<size_t>(0),

test_observer()->observed_data_use().size());

}