Make WaitableEvent's constructor enum-based.

Make WaitableEvent's constructor enum-based.

Cleanup CLs for existing code will follow and conclude
with removal of the boolean based constructor :-)

BUG=612843
Committed: https://crrev.com/e5ff4d6d4f34c5a2c9b1ac5514f94d88912d4135
Cr-Commit-Position: refs/heads/master@{#396989}

[gab, 2016-05-30 14:40:49]

Description was changed from

==========
Make WaitableEvent's constuctor enum-based.

BUG=612843
==========

to

==========
Make WaitableEvent's constuctor enum-based.

Cleanup CLs for existing code will follow and conclude
with removal of the boolean based constructor :-)

BUG=612843
==========

[gab, 2016-05-30 14:41:11]

gab@chromium.org changed reviewers:
+ danakj@chromium.org

[gab, 2016-05-30 14:41:12]

Dana PTAL, as discussed on bug, thanks!

[gab, 2016-05-30 20:18:49]

Description was changed from

==========
Make WaitableEvent's constuctor enum-based.

Cleanup CLs for existing code will follow and conclude
with removal of the boolean based constructor :-)

BUG=612843
==========

to

==========
Make WaitableEvent's constructor enum-based.

Cleanup CLs for existing code will follow and conclude
with removal of the boolean based constructor :-)

BUG=612843
==========

[danakj, 2016-05-31 20:06:41]

LGTM

https://codereview.chromium.org/2020043002/diff/1/base/synchronization/waitab...
File base/synchronization/waitable_event_posix.cc (right):

https://codereview.chromium.org/2020043002/diff/1/base/synchronization/waitab...
base/synchronization/waitable_event_posix.cc:39:
WaitableEvent::WaitableEvent(ResetPolicy reset_policy,
Can you group this with the other constructor more (maybe below it?)

[gab, 2016-05-31 21:00:14]

Thanks, done.

https://codereview.chromium.org/2020043002/diff/1/base/synchronization/waitab...
File base/synchronization/waitable_event_posix.cc (right):

https://codereview.chromium.org/2020043002/diff/1/base/synchronization/waitab...
base/synchronization/waitable_event_posix.cc:39:
WaitableEvent::WaitableEvent(ResetPolicy reset_policy,
On 2016/05/31 20:06:41, danakj wrote:
> Can you group this with the other constructor more (maybe below it?)

Done.

[gab, 2016-05-31 21:00:19]

The CQ bit was checked by gab@chromium.org

[gab, 2016-05-31 21:00:19]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/2020043002/#ps20001
(title: "Move enum constructor in _posix.cc")

[commit-bot: I haz the power, 2016-05-31 21:00:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2020043002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2020043002/20001

[commit-bot: I haz the power, 2016-06-01 00:17:01]

Description was changed from

==========
Make WaitableEvent's constructor enum-based.

Cleanup CLs for existing code will follow and conclude
with removal of the boolean based constructor :-)

BUG=612843
==========

to

==========
Make WaitableEvent's constructor enum-based.

Cleanup CLs for existing code will follow and conclude
with removal of the boolean based constructor :-)

BUG=612843
==========

[commit-bot: I haz the power, 2016-06-01 00:17:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-01 00:18:09]

Description was changed from

==========
Make WaitableEvent's constructor enum-based.

Cleanup CLs for existing code will follow and conclude
with removal of the boolean based constructor :-)

BUG=612843
==========

to

==========
Make WaitableEvent's constructor enum-based.

Cleanup CLs for existing code will follow and conclude
with removal of the boolean based constructor :-)

BUG=612843

Committed: https://crrev.com/e5ff4d6d4f34c5a2c9b1ac5514f94d88912d4135
Cr-Commit-Position: refs/heads/master@{#396989}
==========

[commit-bot: I haz the power, 2016-06-01 00:18:11]

Patchset 2 (id:??) landed as
https://crrev.com/e5ff4d6d4f34c5a2c9b1ac5514f94d88912d4135
Cr-Commit-Position: refs/heads/master@{#396989}