Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2020043002: Make WaitableEvent's constructor enum-based. (Closed)

Created:
4 years, 6 months ago by gab
Modified:
4 years, 6 months ago
Reviewers:
danakj
CC:
chromium-reviews, fdoray
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make WaitableEvent's constructor enum-based. Cleanup CLs for existing code will follow and conclude with removal of the boolean based constructor :-) BUG=612843 Committed: https://crrev.com/e5ff4d6d4f34c5a2c9b1ac5514f94d88912d4135 Cr-Commit-Position: refs/heads/master@{#396989}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move enum constructor in _posix.cc #

Messages

Total messages: 13 (7 generated)
gab
Dana PTAL, as discussed on bug, thanks!
4 years, 6 months ago (2016-05-30 14:41:12 UTC) #3
danakj
LGTM https://codereview.chromium.org/2020043002/diff/1/base/synchronization/waitable_event_posix.cc File base/synchronization/waitable_event_posix.cc (right): https://codereview.chromium.org/2020043002/diff/1/base/synchronization/waitable_event_posix.cc#newcode39 base/synchronization/waitable_event_posix.cc:39: WaitableEvent::WaitableEvent(ResetPolicy reset_policy, Can you group this with the ...
4 years, 6 months ago (2016-05-31 20:06:41 UTC) #5
gab
Thanks, done. https://codereview.chromium.org/2020043002/diff/1/base/synchronization/waitable_event_posix.cc File base/synchronization/waitable_event_posix.cc (right): https://codereview.chromium.org/2020043002/diff/1/base/synchronization/waitable_event_posix.cc#newcode39 base/synchronization/waitable_event_posix.cc:39: WaitableEvent::WaitableEvent(ResetPolicy reset_policy, On 2016/05/31 20:06:41, danakj wrote: ...
4 years, 6 months ago (2016-05-31 21:00:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2020043002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2020043002/20001
4 years, 6 months ago (2016-05-31 21:00:59 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-01 00:17:02 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 00:18:11 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e5ff4d6d4f34c5a2c9b1ac5514f94d88912d4135
Cr-Commit-Position: refs/heads/master@{#396989}

Powered by Google App Engine
This is Rietveld 408576698