Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2030653002: Migrate WaitableEvent to enum-based constructor in dbus/ (Closed)

Created:
4 years, 6 months ago by gab
Modified:
4 years, 6 months ago
Reviewers:
hashimoto
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@WEvent_enums
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate WaitableEvent to enum-based constructor in dbus/ Change automated with clang-tidy (details @ https://crbug.com/612843#c13) BUG=612843 Committed: https://crrev.com/0faddf48a500f60b02b06b197678062ad3c8b856 Cr-Commit-Position: refs/heads/master@{#397374}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M dbus/bus.cc View 1 chunk +2 lines, -1 line 0 comments Download
M dbus/test_service.cc View 1 chunk +2 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (3 generated)
gab
4 years, 6 months ago (2016-06-01 18:26:35 UTC) #1
hashimoto
lgtm I love this!
4 years, 6 months ago (2016-06-02 01:06:13 UTC) #3
gab
On 2016/06/02 01:06:13, hashimoto wrote: > lgtm > > I love this! :-), thanks!
4 years, 6 months ago (2016-06-02 12:23:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030653002/1
4 years, 6 months ago (2016-06-02 12:23:37 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 12:27:06 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 12:28:32 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0faddf48a500f60b02b06b197678062ad3c8b856
Cr-Commit-Position: refs/heads/master@{#397374}

Powered by Google App Engine
This is Rietveld 408576698