Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2023003005: Migrate WaitableEvent to enum-based constructor in tools/ (Closed)

Created:
4 years, 6 months ago by gab
Modified:
4 years, 6 months ago
Reviewers:
scottmg
CC:
chromium-reviews, Dirk Pranke, rginda+watch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@WEvent_enums
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate WaitableEvent to enum-based constructor in tools/ Change automated with clang-tidy (details @ https://crbug.com/612843#c13) BUG=612843 Committed: https://crrev.com/3dbb1f62a6fbc115a027294b982db68d3d21012f Cr-Commit-Position: refs/heads/master@{#397225}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M tools/battor_agent/battor_agent_bin.cc View 1 chunk +2 lines, -1 line 0 comments Download
M tools/gn/input_file_manager.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 2020043002 Patch 20001

Messages

Total messages: 8 (3 generated)
gab
4 years, 6 months ago (2016-06-01 18:32:08 UTC) #1
scottmg
lgtm
4 years, 6 months ago (2016-06-01 18:35:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023003005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023003005/1
4 years, 6 months ago (2016-06-01 18:48:15 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 20:17:50 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 20:20:17 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3dbb1f62a6fbc115a027294b982db68d3d21012f
Cr-Commit-Position: refs/heads/master@{#397225}

Powered by Google App Engine
This is Rietveld 408576698