Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2023343002: Migrate WaitableEvent to enum-based constructor in media/ (Closed)

Created:
4 years, 6 months ago by gab
Modified:
4 years, 6 months ago
Reviewers:
jrummell
CC:
chromium-reviews, imcheng+watch_chromium.org, posciak+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, feature-media-reviews_chromium.org, piman+watch_chromium.org, xjz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@WEvent_enums
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate WaitableEvent to enum-based constructor in media/ Change automated with clang-tidy (details @ https://crbug.com/612843#c13) BUG=612843 Committed: https://crrev.com/0d77c7cb0a3c073cc8e368f4bcf0ce2374622a38 Cr-Commit-Position: refs/heads/master@{#397283}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -29 lines) Patch
M media/audio/audio_output_device.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/audio/clockless_audio_sink.cc View 1 chunk +3 lines, -1 line 0 comments Download
M media/audio/scoped_task_runner_observer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/audio/virtual_audio_input_stream_unittest.cc View 4 chunks +11 lines, -6 lines 0 comments Download
M media/audio/virtual_audio_output_stream_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/base/audio_renderer_mixer_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M media/base/bind_to_current_loop_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/base/pipeline_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/blink/webmediaplayer_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/cast/logging/log_event_dispatcher.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/cast/test/receiver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/cast/test/utility/in_process_receiver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/cast/test/utility/udp_proxy.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M media/filters/blocking_url_protocol.cc View 1 chunk +10 lines, -7 lines 0 comments Download
M media/filters/vpx_video_decoder.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/gpu/ipc/client/gpu_jpeg_decode_accelerator_host.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/gpu/ipc/service/gpu_video_decode_accelerator.cc View 1 chunk +2 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 2020043002 Patch 20001

Messages

Total messages: 8 (3 generated)
gab
4 years, 6 months ago (2016-06-01 18:28:38 UTC) #1
jrummell
lgtm
4 years, 6 months ago (2016-06-01 21:02:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023343002/1
4 years, 6 months ago (2016-06-01 23:40:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 00:00:37 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 00:03:05 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0d77c7cb0a3c073cc8e368f4bcf0ce2374622a38
Cr-Commit-Position: refs/heads/master@{#397283}

Powered by Google App Engine
This is Rietveld 408576698