Migrate WaitableEvent to enum-based constructor in base/

Migrate WaitableEvent to enum-based constructor in base/

Change automated with clang-tidy (details @ https://crbug.com/612843#c13)

BUG=612843
Committed: https://crrev.com/75d723398f481831c2b94325b2bea82c6e03bd56
Cr-Commit-Position: refs/heads/master@{#397244}

[gab, 2016-06-01 18:25:04]

Description was changed from

==========
Migrate WaitableEvent to enum-based constructor in base/
==========

to

==========
Migrate WaitableEvent to enum-based constructor in base/

BUG=612843
R=danakj@chromium.org
==========

[gab, 2016-06-01 18:25:04]

gab@chromium.org changed reviewers:
+ danakj@chromium.org

[danakj, 2016-06-01 18:52:01]

LGTM

[gab, 2016-06-01 18:58:06]

Description was changed from

==========
Migrate WaitableEvent to enum-based constructor in base/

BUG=612843
R=danakj@chromium.org
==========

to

==========
Migrate WaitableEvent to enum-based constructor in base/

Change automated with clang-tidy (details @ https://crbug.com/612843#c13

BUG=612843
==========

[gab, 2016-06-01 18:58:57]

Description was changed from

==========
Migrate WaitableEvent to enum-based constructor in base/

Change automated with clang-tidy (details @ https://crbug.com/612843#c13

BUG=612843
==========

to

==========
Migrate WaitableEvent to enum-based constructor in base/

Change automated with clang-tidy (details @ https://crbug.com/612843#c13)

BUG=612843
==========

[gab, 2016-06-01 19:00:08]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2016-06-01 19:00:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2032603002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2032603002/1

[commit-bot: I haz the power, 2016-06-01 19:01:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-01 19:01:18]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[gab, 2016-06-01 19:16:06]

@etienne FYI (clang-tidy fixed templated code it probably should have skipped)

https://codereview.chromium.org/2032603002/diff/1/base/threading/thread_perft...
File base/threading/thread_perftest.cc (right):

https://codereview.chromium.org/2032603002/diff/1/base/threading/thread_perft...
base/threading/thread_perftest.cc:186:
WaitableEvent::InitialState::NOT_SIGNALED));
@etienneb: weird that clang-tidy made this change given not all instantiations
of this template are happy with it.

This is causing compile failures for patch set #1.

I'll undo it for now and do it manually on its own.

[gab, 2016-06-01 19:16:22]

The CQ bit was checked by gab@chromium.org

[gab, 2016-06-01 19:16:23]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/2032603002/#ps20001
(title: "undo incorrect template change")

[commit-bot: I haz the power, 2016-06-01 19:17:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2032603002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2032603002/20001

[etienneb, 2016-06-01 19:53:26]

etienneb@chromium.org changed reviewers:
+ etienneb@chromium.org

[etienneb, 2016-06-01 19:53:27]

https://codereview.chromium.org/2032603002/diff/1/base/threading/thread_perft...
File base/threading/thread_perftest.cc (right):

https://codereview.chromium.org/2032603002/diff/1/base/threading/thread_perft...
base/threading/thread_perftest.cc:186:
WaitableEvent::InitialState::NOT_SIGNALED));
On 2016/06/01 19:16:05, gab wrote:
> @etienneb: weird that clang-tidy made this change given not all instantiations
> of this template are happy with it.
> 
> This is causing compile failures for patch set #1.
> 
> I'll undo it for now and do it manually on its own.


You can use this to avoid template instantiation.

  isInTemplateInstantiation() or unless(...)

But, to know if something depend on the instantiation, class Expression has this
function: clang::Expr::isInstantiationDependent
 
http://clang.llvm.org/doxygen/classclang_1_1Expr.html#ae6915a41dbc08e0c2ce21a...

I don't remember if there is a matcher, but you can easily write one.

[commit-bot: I haz the power, 2016-06-01 21:15:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-01 21:17:09]

Description was changed from

==========
Migrate WaitableEvent to enum-based constructor in base/

Change automated with clang-tidy (details @ https://crbug.com/612843#c13)

BUG=612843
==========

to

==========
Migrate WaitableEvent to enum-based constructor in base/

Change automated with clang-tidy (details @ https://crbug.com/612843#c13)

BUG=612843

Committed: https://crrev.com/75d723398f481831c2b94325b2bea82c6e03bd56
Cr-Commit-Position: refs/heads/master@{#397244}
==========

[commit-bot: I haz the power, 2016-06-01 21:17:10]

Patchset 2 (id:??) landed as
https://crrev.com/75d723398f481831c2b94325b2bea82c6e03bd56
Cr-Commit-Position: refs/heads/master@{#397244}