Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2028993003: Migrate WaitableEvent to enum-based constructor in jingle/ (Closed)

Created:
4 years, 6 months ago by gab
Modified:
4 years, 6 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@WEvent_enums
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate WaitableEvent to enum-based constructor in jingle/ Change automated with clang-tidy (details @ https://crbug.com/612843#c13) BUG=612843 Committed: https://crrev.com/9b4e2a0a5cf27c6c8097f704da34e4e6eb064dd6 Cr-Commit-Position: refs/heads/master@{#397232}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M jingle/glue/thread_wrapper.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M jingle/glue/thread_wrapper_unittest.cc View 2 chunks +6 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
gab
4 years, 6 months ago (2016-06-01 18:28:02 UTC) #1
Nicolas Zea
lgtm
4 years, 6 months ago (2016-06-01 19:32:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028993003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028993003/1
4 years, 6 months ago (2016-06-01 19:48:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 20:37:23 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 20:40:44 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9b4e2a0a5cf27c6c8097f704da34e4e6eb064dd6
Cr-Commit-Position: refs/heads/master@{#397232}

Powered by Google App Engine
This is Rietveld 408576698