Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 2030663002: Migrate WaitableEvent to enum-based constructor in net/ (Closed)

Created:
4 years, 6 months ago by gab
Modified:
4 years, 6 months ago
Reviewers:
pauljensen
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, mmenke, kinuko+cache_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@WEvent_enums
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate WaitableEvent to enum-based constructor in net/ Change automated with clang-tidy (details @ https://crbug.com/612843#c13) BUG=612843 Committed: https://crrev.com/07efd1082dc0edfa53d8484a98433fc6e968c822 Cr-Commit-Position: refs/heads/master@{#397382}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -32 lines) Patch
M net/base/address_tracker_linux_unittest.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M net/base/keygen_handler_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M net/disk_cache/blockfile/backend_impl.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M net/disk_cache/blockfile/in_flight_io.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M net/dns/serial_worker_unittest.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M net/extras/sqlite/sqlite_persistent_cookie_store_perftest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M net/extras/sqlite/sqlite_persistent_cookie_store_unittest.cc View 3 chunks +10 lines, -5 lines 0 comments Download
M net/log/net_log_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M net/proxy/multi_threaded_proxy_resolver_unittest.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M net/proxy/proxy_config_service_linux_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/proxy/proxy_resolver_v8_tracing.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/tools/quic/test_tools/server_thread.cc View 1 chunk +10 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (3 generated)
gab
4 years, 6 months ago (2016-06-01 18:29:13 UTC) #1
gab
ping pauljensen for net/ (this is one of the last components required for this change, ...
4 years, 6 months ago (2016-06-02 12:44:58 UTC) #3
pauljensen
lgtm
4 years, 6 months ago (2016-06-02 13:27:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030663002/1
4 years, 6 months ago (2016-06-02 13:28:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 13:33:30 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 13:34:55 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/07efd1082dc0edfa53d8484a98433fc6e968c822
Cr-Commit-Position: refs/heads/master@{#397382}

Powered by Google App Engine
This is Rietveld 408576698