Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2028193002: Migrate WaitableEvent to enum-based constructor in components/ (Closed)

Created:
4 years, 6 months ago by gab
Modified:
4 years, 6 months ago
Reviewers:
sdefresne, Sami
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, rouslan+autofill_chromium.org, tfarina, browser-components-watch_chromium.org, yzshen+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, Aaron Boodman, noyau+watch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, darin (slow to review), abarth-chromium, ben+mojo_chromium.org, scheduler-bugs_chromium.org, sync-reviews_chromium.org, Cait (Slow)
Base URL:
https://chromium.googlesource.com/chromium/src.git@WEvent_enums
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate WaitableEvent to enum-based constructor in components/ Change automated with clang-tidy (details @ https://crbug.com/612843#c13) BUG=612843 Committed: https://crrev.com/77f88320bb9a119c44272ff1db588871653a33de Cr-Commit-Position: refs/heads/master@{#397385}

Patch Set 1 #

Patch Set 2 : rm comment explaining true/false #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -33 lines) Patch
M components/autofill/core/browser/webdata/web_data_service_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M components/bookmarks/browser/bookmark_model.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/browser_sync/browser/profile_sync_service_autofill_unittest.cc View 1 5 chunks +14 lines, -7 lines 0 comments Download
M components/font_service/public/cpp/font_service_thread.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M components/leveldb/leveldb_mojo_proxy.cc View 1 chunk +3 lines, -1 line 0 comments Download
M components/mus/gles2/command_buffer_local.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M components/mus/gles2/gpu_state.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/prefs/pref_member_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/scheduler/child/webthread_impl_for_worker_scheduler.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M components/scheduler/child/webthread_impl_for_worker_scheduler_unittest.cc View 4 chunks +12 lines, -4 lines 0 comments Download
M components/storage_monitor/media_storage_util_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/storage_monitor/test_storage_monitor.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/sync_driver/glue/sync_backend_registrar_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M components/sync_driver/glue/ui_model_worker_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M components/sync_driver/non_ui_data_type_controller_unittest.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M components/sync_driver/shared_change_processor_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 2020043002 Patch 20001

Messages

Total messages: 16 (7 generated)
gab
4 years, 6 months ago (2016-06-01 18:25:20 UTC) #1
gab
caitkp (OOO) => sdefresne
4 years, 6 months ago (2016-06-01 18:49:12 UTC) #3
sdefresne
rubberstamp lgtm
4 years, 6 months ago (2016-06-02 09:20:20 UTC) #5
Sami
components/scheduler lgtm.
4 years, 6 months ago (2016-06-02 09:49:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028193002/1
4 years, 6 months ago (2016-06-02 12:24:12 UTC) #9
gab
On 2016/06/02 09:20:20, sdefresne wrote: > rubberstamp lgtm FYI, also just noticed a comment explaining ...
4 years, 6 months ago (2016-06-02 12:29:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028193002/20001
4 years, 6 months ago (2016-06-02 12:29:44 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-02 13:47:16 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 13:48:35 UTC) #16
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/77f88320bb9a119c44272ff1db588871653a33de
Cr-Commit-Position: refs/heads/master@{#397385}

Powered by Google App Engine
This is Rietveld 408576698