Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2027303002: Migrate WaitableEvent to enum-based constructor in ipc/ (Closed)

Created:
4 years, 6 months ago by gab
Modified:
4 years, 6 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, darin-cc_chromium.org, jam, jeremy
Base URL:
https://chromium.googlesource.com/chromium/src.git@WEvent_enums
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate WaitableEvent to enum-based constructor in ipc/ Change automated with clang-tidy (details @ https://crbug.com/612843#c13) BUG=612843 Committed: https://crrev.com/90c2c5c5e952b2e67eb329bb849d4288cede4a42 Cr-Commit-Position: refs/heads/master@{#397230}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -44 lines) Patch
M ipc/ipc_send_fds_test.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M ipc/ipc_sync_channel.cc View 2 chunks +12 lines, -11 lines 0 comments Download
M ipc/ipc_sync_channel_unittest.cc View 8 chunks +59 lines, -26 lines 0 comments Download
M ipc/ipc_sync_message.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ipc/ipc_sync_message_filter.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ipc/unix_domain_socket_util_unittest.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (6 generated)
gab
4 years, 6 months ago (2016-06-01 18:27:33 UTC) #1
gab
@tsepez since jeremy no longer works on chrome and won't do reviews (removed him from ...
4 years, 6 months ago (2016-06-01 19:09:37 UTC) #5
Tom Sepez
lgtm
4 years, 6 months ago (2016-06-01 19:25:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027303002/1
4 years, 6 months ago (2016-06-01 19:49:23 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 20:34:24 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 20:36:26 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/90c2c5c5e952b2e67eb329bb849d4288cede4a42
Cr-Commit-Position: refs/heads/master@{#397230}

Powered by Google App Engine
This is Rietveld 408576698