Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2031713002: Migrate WaitableEvent to enum-based constructor in sync/ (Closed)

Created:
4 years, 6 months ago by gab
Modified:
4 years, 6 months ago
Reviewers:
stanisc
CC:
chromium-reviews, sync-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@WEvent_enums
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate WaitableEvent to enum-based constructor in sync/ Change automated with clang-tidy (details @ https://crbug.com/612843#c13) BUG=612843 Committed: https://crrev.com/560392b6d278bf932ba30f8130902a4292d88e7b Cr-Commit-Position: refs/heads/master@{#397237}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -21 lines) Patch
M sync/internal_api/attachments/attachment_service_proxy_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M sync/internal_api/http_bridge.cc View 1 chunk +2 lines, -1 line 0 comments Download
M sync/internal_api/http_bridge_unittest.cc View 4 chunks +21 lines, -7 lines 0 comments Download
M sync/internal_api/public/base/cancelation_signal_unittest.cc View 2 chunks +10 lines, -7 lines 0 comments Download
M sync/internal_api/public/engine/model_safe_worker.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M sync/internal_api/syncapi_server_connection_manager_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M sync/test/fake_server/fake_server_http_post_provider.cc View 1 chunk +3 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 2020043002 Patch 20001

Messages

Total messages: 8 (3 generated)
gab
4 years, 6 months ago (2016-06-01 18:31:39 UTC) #1
stanisc
lgtm
4 years, 6 months ago (2016-06-01 20:38:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2031713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2031713002/1
4 years, 6 months ago (2016-06-01 20:44:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 20:48:58 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 20:51:33 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/560392b6d278bf932ba30f8130902a4292d88e7b
Cr-Commit-Position: refs/heads/master@{#397237}

Powered by Google App Engine
This is Rietveld 408576698