Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2027313002: Migrate WaitableEvent to enum-based constructor in ppapi/ (Closed)

Created:
4 years, 6 months ago by gab
Modified:
4 years, 6 months ago
Reviewers:
bbudge
CC:
chromium-reviews, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@WEvent_enums
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate WaitableEvent to enum-based constructor in ppapi/ Change automated with clang-tidy (details @ https://crbug.com/612843#c13) BUG=612843 Committed: https://crrev.com/f40c0a5e0ccac827a449c314e920dcb9bfb7305c Cr-Commit-Position: refs/heads/master@{#397221}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -13 lines) Patch
M ppapi/host/resource_message_filter_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ppapi/proxy/ppapi_proxy_test.cc View 4 chunks +13 lines, -5 lines 0 comments Download
M ppapi/proxy/ppp_instance_proxy_unittest.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M ppapi/proxy/ppp_messaging_proxy_perftest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ppapi/proxy/ppp_messaging_proxy_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ppapi/proxy/tracked_callback_unittest.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M ppapi/proxy/video_encoder_resource_unittest.cc View 1 chunk +4 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 2020043002 Patch 20001

Messages

Total messages: 8 (3 generated)
gab
4 years, 6 months ago (2016-06-01 18:29:47 UTC) #1
bbudge
lgtm
4 years, 6 months ago (2016-06-01 19:23:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027313002/1
4 years, 6 months ago (2016-06-01 19:26:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 20:11:01 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 20:12:59 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f40c0a5e0ccac827a449c314e920dcb9bfb7305c
Cr-Commit-Position: refs/heads/master@{#397221}

Powered by Google App Engine
This is Rietveld 408576698