Make WaitableEvent's constructor enum-based.

base/synchronization/waitable_event_posix.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <vector>
 
 #include "base/logging.h"
@@ skipping 18 matching lines @@
 // from the list.
 //
 // Waiting on multiple events is handled by adding a single, synchronous wait to
 // the wait-list of many events. An event passes a pointer to itself when
 // firing a waiter and so we can store that pointer to find out which event
 // triggered.
 // -----------------------------------------------------------------------------
 
 namespace base {
 
+WaitableEvent::WaitableEvent(ResetPolicy reset_policy,

[danakj, 2016/05/31 20:06:41]

Can you group this with the other constructor more (maybe below it?)

[gab, 2016/05/31 21:00:13]

Done.

+                             InitialState initial_state)
+    : WaitableEvent(reset_policy == ResetPolicy::MANUAL,
+                    initial_state == InitialState::SIGNALED) {}
+
 // -----------------------------------------------------------------------------
 // This is just an abstract base class for waking the two types of waiters
 // -----------------------------------------------------------------------------
 WaitableEvent::WaitableEvent(bool manual_reset, bool initially_signaled)
     : kernel_(new WaitableEventKernel(manual_reset, initially_signaled)) {
 }
 
 WaitableEvent::~WaitableEvent() {
 }
 
@@ skipping 359 matching lines @@
       return true;
     }
   }
 
   return false;
 }
 
 // -----------------------------------------------------------------------------
 
 }  // namespace base