Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2031693002: Migrate WaitableEvent to enum-based constructor in services/ (Closed)

Created:
4 years, 6 months ago by gab
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@WEvent_enums
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate WaitableEvent to enum-based constructor in services/ Change automated with clang-tidy (details @ https://crbug.com/612843#c13) BUG=612843 Committed: https://crrev.com/f789bc6d984264de917571e7f03bbf7a6c472c30 Cr-Commit-Position: refs/heads/master@{#397215}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M services/shell/background/background_shell.cc View 1 chunk +2 lines, -1 line 0 comments Download
M services/shell/runner/host/child_process_base.cc View 1 chunk +4 lines, -1 line 0 comments Download
M services/shell/runner/host/child_process_host.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M services/shell/standalone/tracer.cc View 1 chunk +3 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 2020043002 Patch 20001

Messages

Total messages: 8 (3 generated)
gab
4 years, 6 months ago (2016-06-01 18:30:43 UTC) #1
Ken Rockot(use gerrit already)
lgtm
4 years, 6 months ago (2016-06-01 19:14:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2031693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2031693002/1
4 years, 6 months ago (2016-06-01 19:26:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 20:01:35 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 20:02:48 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f789bc6d984264de917571e7f03bbf7a6c472c30
Cr-Commit-Position: refs/heads/master@{#397215}

Powered by Google App Engine
This is Rietveld 408576698