Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2026253003: Migrate WaitableEvent to enum-based constructor in content/ (Closed)

Created:
4 years, 6 months ago by gab
Modified:
4 years, 6 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, tzik, posciak+watch_chromium.org, nasko+codewatch_chromium.org, miu+watch_chromium.org, cbentzel+watch_chromium.org, jam, darin-cc_chromium.org, jkarlin+watch_chromium.org, devtools-reviews_chromium.org, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nhiroki, feature-media-reviews_chromium.org, timvolodine, mcasas+watch+vc_chromium.org, mlamouri+watch-sensors_chromium.org, piman+watch_chromium.org, jsbell+idb_chromium.org, michaeln, riju_, pfeldman, cmumford, mkwst+moarreviews-renderer_chromium.org, kinuko+fileapi, Michael van Ouwerkerk
Base URL:
https://chromium.googlesource.com/chromium/src.git@WEvent_enums
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate WaitableEvent to enum-based constructor in content/ Change automated with clang-tidy (details @ https://crbug.com/612843#c13) BUG=612843 Committed: https://crrev.com/d6f9bff227238cd52644eac6bb49e6502bbb8c37 Cr-Commit-Position: refs/heads/master@{#397386}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -71 lines) Patch
M content/browser/appcache/appcache_request_handler_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/appcache/appcache_response_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/appcache/appcache_storage_impl_unittest.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M content/browser/appcache/appcache_update_job_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/appcache/appcache_url_request_job_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/browser_shutdown_profile_dumper.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/device_sensors/data_fetcher_shared_memory_base_unittest.cc View 1 chunk +27 lines, -12 lines 0 comments Download
M content/browser/device_sensors/device_inertial_sensor_browsertest.cc View 2 chunks +16 lines, -7 lines 0 comments Download
M content/browser/frame_host/debug_urls.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/frame_host/interstitial_page_impl_browsertest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/gamepad/gamepad_test_helpers.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/gpu/browser_gpu_channel_host_factory.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M content/browser/gpu/browser_gpu_memory_buffer_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_browsertest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/media/capture/desktop_capture_device_unittest.cc View 6 chunks +18 lines, -6 lines 0 comments Download
M content/browser/media/capture/web_contents_audio_input_stream_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/message_port_provider_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/net/quota_policy_cookie_store_unittest.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M content/browser/plugin_data_remover_impl.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/child/blink_platform_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/child/child_process.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/child/fileapi/webfilesystem_impl.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/child/fileapi/webfilewriter_impl.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M content/public/test/browser_test_utils.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/renderer/devtools/v8_sampling_profiler.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/renderer/devtools/v8_sampling_profiler_browsertest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/renderer/media/media_stream_audio_unittest.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M content/renderer/media/rtc_peer_connection_handler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/rtc_video_decoder.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/rtc_video_decoder_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/rtc_video_encoder.cc View 4 chunks +12 lines, -4 lines 0 comments Download
M content/renderer/media/webrtc/peer_connection_dependency_factory.cc View 2 chunks +9 lines, -3 lines 0 comments Download

Depends on Patchset:

Issue 2020043002 Patch 20001

Messages

Total messages: 13 (6 generated)
gab
4 years, 6 months ago (2016-06-01 18:26:06 UTC) #1
Avi (use Gerrit)
lgtm
4 years, 6 months ago (2016-06-01 18:55:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2026253003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2026253003/1
4 years, 6 months ago (2016-06-01 19:02:10 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/222811)
4 years, 6 months ago (2016-06-01 21:09:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2026253003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2026253003/1
4 years, 6 months ago (2016-06-02 13:08:37 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 13:48:33 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 13:50:32 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d6f9bff227238cd52644eac6bb49e6502bbb8c37
Cr-Commit-Position: refs/heads/master@{#397386}

Powered by Google App Engine
This is Rietveld 408576698