Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2011713003: Roll skia to 8cc209111876b7c78b5ec577c9221d8ed5e21024 (Closed)

Created:
4 years, 7 months ago by jeffbrown
Modified:
4 years, 7 months ago
Reviewers:
abarth, mikejurka
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Roll skia to 8cc209111876b7c78b5ec577c9221d8ed5e21024 Replaced all uses of skia::RefPtr<> with sk_sp<>. Updated build scripts, largely borrowing changes from Flutter with some modifications for running in a pure Mojo environment. We could probably delete more of the support code for native platforms but I'll leave that for later. Added optimized convolution algorithms since they might be useful for composition and they were already in the Flutter repo. R=mikejurka@google.com Committed: https://chromium.googlesource.com/external/mojo/+/332b5ed07fddf1409de200fdf96f830609e98996

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2719 lines, -4918 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M PRESUBMIT.py View 4 chunks +4 lines, -4 lines 0 comments Download
M apps/moterm/moterm_view.h View 1 chunk +1 line, -1 line 0 comments Download
M apps/moterm/moterm_view.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M examples/ui/jank/jank.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M examples/ui/noodles/frame.h View 3 chunks +3 lines, -3 lines 0 comments Download
M examples/ui/noodles/frame.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/ui/noodles/noodles_view.h View 2 chunks +2 lines, -2 lines 0 comments Download
M examples/ui/noodles/noodles_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M examples/ui/pdf_viewer/pdf_viewer.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M examples/ui/png_viewer/png_viewer.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M mojo/skia/ganesh_context.h View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/skia/ganesh_context.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M mojo/skia/ganesh_framebuffer_surface.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/skia/ganesh_framebuffer_surface.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/skia/ganesh_image_factory.h View 2 chunks +7 lines, -8 lines 0 comments Download
M mojo/skia/ganesh_image_factory.cc View 2 chunks +9 lines, -10 lines 0 comments Download
M mojo/skia/ganesh_texture_surface.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/skia/ganesh_texture_surface.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/skia/gl_bindings_skia.h View 2 chunks +2 lines, -1 line 0 comments Download
M mojo/skia/gl_bindings_skia.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/skia/type_converters.h View 1 chunk +1 line, -1 line 0 comments Download
M services/gfx/compositor/graph/nodes.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/gfx/compositor/graph/snapshot.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/gfx/compositor/graph/transform_pair.h View 1 chunk +1 line, -1 line 0 comments Download
M services/gfx/compositor/render/render_frame.h View 4 chunks +4 lines, -4 lines 0 comments Download
M services/gfx/compositor/render/render_frame.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/gfx/compositor/render/render_image.h View 3 chunks +4 lines, -4 lines 0 comments Download
M services/gfx/compositor/render/render_image.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M skia/BUILD.gn View 9 chunks +43 lines, -140 lines 0 comments Download
M skia/ext/SkMemory_new_handler.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
D skia/ext/bitmap_platform_device.h View 1 chunk +0 lines, -34 lines 0 comments Download
D skia/ext/bitmap_platform_device_mac.h View 1 chunk +0 lines, -94 lines 0 comments Download
D skia/ext/bitmap_platform_device_mac.cc View 1 chunk +0 lines, -323 lines 0 comments Download
D skia/ext/bitmap_platform_device_mac_unittest.cc View 1 chunk +0 lines, -69 lines 0 comments Download
D skia/ext/bitmap_platform_device_skia.h View 1 chunk +0 lines, -51 lines 0 comments Download
D skia/ext/bitmap_platform_device_skia.cc View 1 chunk +0 lines, -80 lines 0 comments Download
D skia/ext/bitmap_platform_device_win.h View 1 chunk +0 lines, -120 lines 0 comments Download
D skia/ext/bitmap_platform_device_win.cc View 1 chunk +0 lines, -328 lines 0 comments Download
A skia/ext/convolver.h View 1 chunk +235 lines, -0 lines 0 comments Download
A skia/ext/convolver.cc View 1 chunk +705 lines, -0 lines 0 comments Download
A skia/ext/convolver_SSE2.h View 1 chunk +27 lines, -0 lines 0 comments Download
A skia/ext/convolver_SSE2.cc View 1 chunk +448 lines, -0 lines 0 comments Download
A skia/ext/convolver_mips_dspr2.h View 1 chunk +25 lines, -0 lines 0 comments Download
A skia/ext/convolver_mips_dspr2.cc View 1 chunk +516 lines, -0 lines 0 comments Download
A skia/ext/convolver_unittest.cc View 1 chunk +530 lines, -0 lines 0 comments Download
D skia/ext/opacity_draw_filter.h View 1 chunk +0 lines, -33 lines 0 comments Download
D skia/ext/opacity_draw_filter.cc View 1 chunk +0 lines, -27 lines 0 comments Download
D skia/ext/platform_canvas.h View 1 chunk +0 lines, -187 lines 0 comments Download
D skia/ext/platform_canvas.cc View 1 chunk +0 lines, -63 lines 0 comments Download
D skia/ext/platform_canvas_unittest.cc View 1 chunk +0 lines, -453 lines 0 comments Download
D skia/ext/platform_device.h View 1 chunk +0 lines, -150 lines 0 comments Download
D skia/ext/platform_device.cc View 1 chunk +0 lines, -92 lines 0 comments Download
D skia/ext/platform_device_linux.cc View 1 chunk +0 lines, -17 lines 0 comments Download
D skia/ext/platform_device_mac.cc View 1 chunk +0 lines, -33 lines 0 comments Download
D skia/ext/platform_device_win.cc View 1 chunk +0 lines, -233 lines 0 comments Download
D skia/ext/refptr.h View 1 chunk +0 lines, -118 lines 0 comments Download
D skia/ext/refptr_unittest.cc View 1 chunk +0 lines, -125 lines 0 comments Download
D skia/ext/skia_utils_base.h View 1 chunk +0 lines, -33 lines 0 comments Download
D skia/ext/skia_utils_base.cc View 1 chunk +0 lines, -53 lines 0 comments Download
D skia/ext/skia_utils_ios.h View 1 chunk +0 lines, -40 lines 0 comments Download
D skia/ext/skia_utils_ios.mm View 1 chunk +0 lines, -126 lines 0 comments Download
D skia/ext/skia_utils_ios_unittest.mm View 1 chunk +0 lines, -753 lines 0 comments Download
D skia/ext/skia_utils_mac.h View 1 chunk +0 lines, -151 lines 0 comments Download
D skia/ext/skia_utils_mac.mm View 1 chunk +0 lines, -462 lines 0 comments Download
D skia/ext/skia_utils_mac_unittest.mm View 1 chunk +0 lines, -247 lines 0 comments Download
D skia/ext/skia_utils_win.h View 1 chunk +0 lines, -49 lines 0 comments Download
D skia/ext/skia_utils_win.cc View 1 chunk +0 lines, -62 lines 0 comments Download
A skia/skia_gn_files.gypi View 1 chunk +37 lines, -0 lines 0 comments Download
M ui/gfx/hud_font.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/gfx/hud_font.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/gfx/skia_util.h View 3 chunks +8 lines, -8 lines 0 comments Download
M ui/gfx/skia_util.cc View 3 chunks +16 lines, -18 lines 0 comments Download
M ui/gfx/transform.h View 3 chunks +4 lines, -9 lines 0 comments Download
M ui/ozone/demo/software_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/drm_buffer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_buffer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_console_buffer.h View 3 chunks +3 lines, -5 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_console_buffer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_surface.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_surface.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_surface_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_window_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/ozone/platform/drm/gpu/screen_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/drm/test/mock_drm_device.h View 3 chunks +3 lines, -5 lines 0 comments Download
M ui/ozone/platform/drm/test/mock_drm_device.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/ozone/platform/test/test_window_manager.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/ozone/public/surface_ozone_canvas.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
jeffbrown
Well... that was fun...
4 years, 7 months ago (2016-05-25 22:16:05 UTC) #2
mikejurka
lgtm!
4 years, 7 months ago (2016-05-26 00:25:22 UTC) #3
jeffbrown
4 years, 7 months ago (2016-05-26 20:03:04 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
332b5ed07fddf1409de200fdf96f830609e98996 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698