PRESUBMIT.py - Issue 2011713003: Roll skia to 8cc209111876b7c78b5ec577c9221d8ed5e21024

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 2011713003: Roll skia to 8cc209111876b7c78b5ec577c9221d8ed5e21024 (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index abde0260b6f3de5621ed1a56fb62c4225fa43ada..7b8d1745cff0909a91f3add60c003435db3ec3a1 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -87,7 +87,7 @@ _BANNED_CPP_FUNCTIONS = (

'SkRefPtr',

(

'The use of SkRefPtr is prohibited. ',

- 'Please use skia::RefPtr instead.'

+ 'Please use sk_sp instead.'

True,

(),

@@ -96,7 +96,7 @@ _BANNED_CPP_FUNCTIONS = (

'SkAutoRef',

(

'The indirect use of SkRefPtr via SkAutoRef is prohibited. ',

- 'Please use skia::RefPtr instead.'

+ 'Please use sk_sp instead.'

True,

(),

@@ -105,7 +105,7 @@ _BANNED_CPP_FUNCTIONS = (

'SkAutoTUnref',

(

'The use of SkAutoTUnref is dangerous because it implicitly ',

- 'converts to a raw pointer. Please use skia::RefPtr instead.'

+ 'converts to a raw pointer. Please use sk_sp instead.'

True,

(),

@@ -115,7 +115,7 @@ _BANNED_CPP_FUNCTIONS = (

(

'The indirect use of SkAutoTUnref through SkAutoUnref is dangerous ',

'because it implicitly converts to a raw pointer. ',

- 'Please use skia::RefPtr instead.'

+ 'Please use sk_sp instead.'

True,

(),

« no previous file with comments | « DEPS ('k') | apps/moterm/moterm_view.h » ('j') | no next file with comments »