OLD | NEW |
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. |
2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
4 | 4 |
5 """Top-level presubmit script for Chromium. | 5 """Top-level presubmit script for Chromium. |
6 | 6 |
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
8 for more details about the presubmit API built into gcl. | 8 for more details about the presubmit API built into gcl. |
9 """ | 9 """ |
10 | 10 |
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
80 True, | 80 True, |
81 ( | 81 ( |
82 r"^base/process/process_metrics_linux\.cc$", | 82 r"^base/process/process_metrics_linux\.cc$", |
83 r"^mojo/edk/embedder/simple_platform_shared_buffer_posix\.cc$", | 83 r"^mojo/edk/embedder/simple_platform_shared_buffer_posix\.cc$", |
84 ), | 84 ), |
85 ), | 85 ), |
86 ( | 86 ( |
87 'SkRefPtr', | 87 'SkRefPtr', |
88 ( | 88 ( |
89 'The use of SkRefPtr is prohibited. ', | 89 'The use of SkRefPtr is prohibited. ', |
90 'Please use skia::RefPtr instead.' | 90 'Please use sk_sp instead.' |
91 ), | 91 ), |
92 True, | 92 True, |
93 (), | 93 (), |
94 ), | 94 ), |
95 ( | 95 ( |
96 'SkAutoRef', | 96 'SkAutoRef', |
97 ( | 97 ( |
98 'The indirect use of SkRefPtr via SkAutoRef is prohibited. ', | 98 'The indirect use of SkRefPtr via SkAutoRef is prohibited. ', |
99 'Please use skia::RefPtr instead.' | 99 'Please use sk_sp instead.' |
100 ), | 100 ), |
101 True, | 101 True, |
102 (), | 102 (), |
103 ), | 103 ), |
104 ( | 104 ( |
105 'SkAutoTUnref', | 105 'SkAutoTUnref', |
106 ( | 106 ( |
107 'The use of SkAutoTUnref is dangerous because it implicitly ', | 107 'The use of SkAutoTUnref is dangerous because it implicitly ', |
108 'converts to a raw pointer. Please use skia::RefPtr instead.' | 108 'converts to a raw pointer. Please use sk_sp instead.' |
109 ), | 109 ), |
110 True, | 110 True, |
111 (), | 111 (), |
112 ), | 112 ), |
113 ( | 113 ( |
114 'SkAutoUnref', | 114 'SkAutoUnref', |
115 ( | 115 ( |
116 'The indirect use of SkAutoTUnref through SkAutoUnref is dangerous ', | 116 'The indirect use of SkAutoTUnref through SkAutoUnref is dangerous ', |
117 'because it implicitly converts to a raw pointer. ', | 117 'because it implicitly converts to a raw pointer. ', |
118 'Please use skia::RefPtr instead.' | 118 'Please use sk_sp instead.' |
119 ), | 119 ), |
120 True, | 120 True, |
121 (), | 121 (), |
122 ), | 122 ), |
123 ( | 123 ( |
124 r'/HANDLE_EINTR\(.*close', | 124 r'/HANDLE_EINTR\(.*close', |
125 ( | 125 ( |
126 'HANDLE_EINTR(close) is invalid. If close fails with EINTR, the file', | 126 'HANDLE_EINTR(close) is invalid. If close fails with EINTR, the file', |
127 'descriptor will be closed, and it is incorrect to retry the close.', | 127 'descriptor will be closed, and it is incorrect to retry the close.', |
128 'Either call close directly and ignore its return value, or wrap close', | 128 'Either call close directly and ignore its return value, or wrap close', |
(...skipping 1021 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
1150 'Mojo Linux ASan Try', | 1150 'Mojo Linux ASan Try', |
1151 'Mojo Linux Try', | 1151 'Mojo Linux Try', |
1152 ] | 1152 ] |
1153 | 1153 |
1154 return GetDefaultTryConfigs(builders) | 1154 return GetDefaultTryConfigs(builders) |
1155 | 1155 |
1156 def PostUploadHook(cl, change, output_api): | 1156 def PostUploadHook(cl, change, output_api): |
1157 import subprocess | 1157 import subprocess |
1158 subprocess.check_call(["git", "cl", "try"]) | 1158 subprocess.check_call(["git", "cl", "try"]) |
1159 return [] | 1159 return [] |
OLD | NEW |