Drop |languages| from {Format,Elide}Url* and IDNToUnicode

Drop |languages| from FormatUrl*() and ElideUrl()

In http://crrev.com/382029, IDN display policy was revised to be
independent of Accept-Languages (A-L).  Therefore, IDNToUnicode(), FormatUrl*()
and ElideUrl() do not need |languages| argument any more.
( ElideUrl() can pass A-L down to gfx string drawing/measuring API help
their font selection, but there's no gfx string drawing/measuring API taking
into account A-L values in the font selection atm.)

Drop it in the API and fix all the call sites. There is a huge ripple effect
and a lot of files have to be fixed up.

BUG=336973
TEST=Builds on all platforms and pass all the tests pass
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel

Committed: https://crrev.com/1fb76469391f6e7e2a846c27a095d57b54b50738
Cr-Commit-Position: refs/heads/master@{#385299}

[jungshik at Google, 2016-03-29 19:11:28]

Description was changed from

==========
Drop |languages| from FormatUrl* and ElideUrl

WiP; far from over

BUG=...
TEST=..
==========

to

==========
Drop |languages| from FormatUrl* and ElideUrl

WiP; far from over

BUG=...
TEST=..
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[jungshik at Google, 2016-03-30 07:06:08]

The CQ bit was checked by jshin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-30 07:06:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1841653003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1841653003/60001

[commit-bot: I haz the power, 2016-03-30 07:10:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-30 07:10:14]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jungshik at Google, 2016-03-30 08:55:02]

The CQ bit was checked by jshin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-30 08:55:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1841653003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1841653003/100001

[jungshik at Google, 2016-03-30 08:55:37]

The CQ bit was unchecked by jshin@chromium.org

[jungshik at Google, 2016-03-30 08:55:40]

The CQ bit was checked by jshin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-30 08:55:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1841653003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1841653003/100001

[commit-bot: I haz the power, 2016-03-30 08:58:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-30 08:58:36]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jungshik at Google, 2016-03-30 17:28:57]

The CQ bit was checked by jshin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-30 17:29:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1841653003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1841653003/120001

[jungshik at Google, 2016-03-30 17:30:09]

Description was changed from

==========
Drop |languages| from FormatUrl* and ElideUrl

WiP; far from over

BUG=...
TEST=..
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Drop |languages| from FormatUrl* and ElideUrl


BUG=...
TEST=Builds on all platforms and pass all the tests
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-03-30 17:40:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-30 17:40:02]

Dry run: Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[jungshik at Google, 2016-03-30 17:55:34]

Description was changed from

==========
Drop |languages| from FormatUrl* and ElideUrl


BUG=...
TEST=Builds on all platforms and pass all the tests
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Drop |languages| from FormatUrl*() and ElideUrl()


In http://crrev.com/382029, IDN display policy was revised to be
independent of Accept-Languages.  Therefore, IDNToUnicode(), FormatUrl*()
and ElideUrl() do not need |languages| argument any more.

Drop it in the API and fix all the call sites. There is a huge ripple effect
and a lot of files have to be fixed up.

BUG=336973
TEST=Builds on all platforms and pass all the tests pass
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[jungshik at Google, 2016-03-30 18:30:23]

The CQ bit was checked by jshin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-30 18:30:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1841653003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1841653003/140001

[commit-bot: I haz the power, 2016-03-30 18:39:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-30 18:39:38]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[jungshik at Google, 2016-03-30 20:37:48]

Description was changed from

==========
Drop |languages| from FormatUrl*() and ElideUrl()


In http://crrev.com/382029, IDN display policy was revised to be
independent of Accept-Languages.  Therefore, IDNToUnicode(), FormatUrl*()
and ElideUrl() do not need |languages| argument any more.

Drop it in the API and fix all the call sites. There is a huge ripple effect
and a lot of files have to be fixed up.

BUG=336973
TEST=Builds on all platforms and pass all the tests pass
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Drop |languages| from FormatUrl*() and ElideUrl()


In http://crrev.com/382029, IDN display policy was revised to be
independent of Accept-Languages.  Therefore, IDNToUnicode(), FormatUrl*()
and ElideUrl() do not need |languages| argument any more.

Drop it in the API and fix all the call sites. There is a huge ripple effect
and a lot of files have to be fixed up.

BUG=336973
TEST=Builds on all platforms and pass all the tests pass
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[jungshik at Google, 2016-03-30 22:20:21]

The CQ bit was checked by jshin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-30 22:20:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1841653003/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1841653003/160001

[commit-bot: I haz the power, 2016-03-30 22:30:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-30 22:30:29]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[jungshik at Google, 2016-03-30 22:57:18]

The CQ bit was checked by jshin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-30 22:57:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1841653003/170001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1841653003/170001

[commit-bot: I haz the power, 2016-03-30 23:02:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-30 23:02:38]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_blink_oilpan_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_blink_oil...)
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_site_isolation on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_site_isol...)
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jungshik at Google, 2016-03-31 05:18:05]

Description was changed from

==========
Drop |languages| from FormatUrl*() and ElideUrl()


In http://crrev.com/382029, IDN display policy was revised to be
independent of Accept-Languages.  Therefore, IDNToUnicode(), FormatUrl*()
and ElideUrl() do not need |languages| argument any more.

Drop it in the API and fix all the call sites. There is a huge ripple effect
and a lot of files have to be fixed up.

BUG=336973
TEST=Builds on all platforms and pass all the tests pass
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Drop |languages| from FormatUrl*() and ElideUrl()


In http://crrev.com/382029, IDN display policy was revised to be
independent of Accept-Languages.  Therefore, IDNToUnicode(), FormatUrl*()
and ElideUrl() do not need |languages| argument any more.

Drop it in the API and fix all the call sites. There is a huge ripple effect
and a lot of files have to be fixed up.

BUG=336973
TEST=Builds on all platforms and pass all the tests pass
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel
==========

[jungshik at Google, 2016-03-31 05:18:54]

The CQ bit was checked by jshin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-31 05:19:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1841653003/190001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1841653003/190001

[commit-bot: I haz the power, 2016-03-31 05:34:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 05:34:57]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[jungshik at Google, 2016-03-31 07:14:21]

The CQ bit was checked by jshin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-31 07:14:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1841653003/210001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1841653003/210001

[commit-bot: I haz the power, 2016-03-31 07:32:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 07:32:57]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[jungshik at Google, 2016-03-31 08:31:30]

The CQ bit was checked by jshin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-31 08:31:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1841653003/230001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1841653003/230001

[commit-bot: I haz the power, 2016-03-31 08:54:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 08:54:48]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[jungshik at Google, 2016-03-31 19:10:40]

The CQ bit was checked by jshin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-31 19:11:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1841653003/270001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1841653003/270001

[commit-bot: I haz the power, 2016-03-31 19:37:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 19:37:36]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[jungshik at Google, 2016-03-31 21:29:43]

The CQ bit was checked by jshin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-31 21:30:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1841653003/290001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1841653003/290001

[commit-bot: I haz the power, 2016-03-31 21:46:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 21:46:12]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jungshik at Google, 2016-04-01 23:20:57]

The CQ bit was checked by jshin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-01 23:22:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1841653003/310001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1841653003/310001

[jungshik at Google, 2016-04-02 00:08:12]

jshin@chromium.org changed reviewers:
+ avi@chromium.org, esprehn@chromium.org, jochen@chromium.org,
pkasting@chromium.org, torne@chromium.org, yfriedman@chromium.org

[jungshik at Google, 2016-04-02 00:08:15]

Sorry that this CL is huge. I didn't expect it to grow this much. Most of
changes are dropping |languages| and the code to get its value. 


pkasting@ : can you take a look focusing on url_formatter, autocomplete, and
omnibox ? 

avi@:  chrome/browser/ui/, components/app_modal, 

esprehn@: content/renderer - blink api 

yfriedman@: chrome/browser/android 

jochen@: blink, chrome/browser/ (subdirs you feel like looking at)

torne@: android_webview 

Thank you !

[jungshik at Google, 2016-04-02 00:12:49]

jshin@chromium.org changed reviewers:
+ sdefresne@chromium.org

[jungshik at Google, 2016-04-02 00:12:51]

sdefresne@: can you take a look at ios/ changes? Thanks

[jungshik at Google, 2016-04-02 00:17:26]

jshin@chromium.org changed reviewers:
+ fsamuel@chromium.org

[jungshik at Google, 2016-04-02 00:17:28]

fsamuel@ : can you review changes in extensions/browser/guest_view? Thanks

[jungshik at Google, 2016-04-02 00:22:09]

Description was changed from

==========
Drop |languages| from FormatUrl*() and ElideUrl()


In http://crrev.com/382029, IDN display policy was revised to be
independent of Accept-Languages.  Therefore, IDNToUnicode(), FormatUrl*()
and ElideUrl() do not need |languages| argument any more.

Drop it in the API and fix all the call sites. There is a huge ripple effect
and a lot of files have to be fixed up.

BUG=336973
TEST=Builds on all platforms and pass all the tests pass
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel
==========

to

==========
Drop |languages| from FormatUrl*() and ElideUrl()


In http://crrev.com/382029, IDN display policy was revised to be
independent of Accept-Languages (A-L).  Therefore, IDNToUnicode(), FormatUrl*()
and ElideUrl() do not need |languages| argument any more.
( ElideUrl() can pass A-L down to gfx string drawing/measuring API help
their font selection, but there's no gfx string drawing/measuring API taking
into account A-L values in the font selection atm.)

Drop it in the API and fix all the call sites. There is a huge ripple effect
and a lot of files have to be fixed up.

BUG=336973
TEST=Builds on all platforms and pass all the tests pass
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel
==========

[Fady Samuel, 2016-04-02 00:28:19]

guest_view lgtm

[Avi (use Gerrit), 2016-04-02 01:12:16]

lgtm

[esprehn, 2016-04-02 01:16:27]

lgtm, sad webkit apparently had no tests. :(

[commit-bot: I haz the power, 2016-04-02 01:59:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-02 01:59:44]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2016-04-03 11:15:57]

lgtm

[Torne, 2016-04-04 10:30:54]

android_webview LGTM

[jungshik at Google, 2016-04-04 18:31:38]

jshin@chromium.org changed reviewers:
+ stuartmorgan@chromium.org

[jungshik at Google, 2016-04-04 18:31:41]

stuartmorgan@: can you take a look at ios/{web,chrome}? Thanks

[sdefresne, 2016-04-04 19:03:03]

ios/ lgtm

[jungshik at Google, 2016-04-04 20:25:18]

Thank you all for the review/approval !

Peter, do you have any concern in url_formatter/omnibox/autocomplete?

[Peter Kasting, 2016-04-05 02:42:33]

LGTM

https://codereview.chromium.org/1841653003/diff/310001/chrome/browser/android...
File chrome/browser/android/omnibox/autocomplete_controller_android.cc (right):

https://codereview.chromium.org/1841653003/diff/310001/chrome/browser/android...
chrome/browser/android/omnibox/autocomplete_controller_android.cc:559:
base::string16 AutocompleteControllerAndroid::FormatURLUsingAcceptLanguages(
This function name is now inaccurate.

https://codereview.chromium.org/1841653003/diff/310001/components/omnibox/bro...
File components/omnibox/browser/bookmark_provider.cc (right):

https://codereview.chromium.org/1841653003/diff/310001/components/omnibox/bro...
components/omnibox/browser/bookmark_provider.cc:60: bookmark_model_(nullptr) {
Nit: Eliminates need for function body:

      bookmark_model_(client ? client ->GetBookmarkModel() : nullptr) {

https://codereview.chromium.org/1841653003/diff/310001/components/omnibox/bro...
File components/omnibox/browser/history_quick_provider.cc (right):

https://codereview.chromium.org/1841653003/diff/310001/components/omnibox/bro...
components/omnibox/browser/history_quick_provider.cc:245:
client()->GetTemplateURLService());
Nit: All lines of args must be indented the same

https://codereview.chromium.org/1841653003/diff/310001/components/omnibox/bro...
File components/omnibox/browser/history_url_provider.cc (right):

https://codereview.chromium.org/1841653003/diff/310001/components/omnibox/bro...
components/omnibox/browser/history_url_provider.cc:1136: MatchType match_type,
This parameter is no longer needed.

https://codereview.chromium.org/1841653003/diff/310001/components/omnibox/bro...
File components/omnibox/browser/in_memory_url_index.cc (right):

https://codereview.chromium.org/1841653003/diff/310001/components/omnibox/bro...
components/omnibox/browser/in_memory_url_index.cc:280: this, 
scheme_whitelist_)),
Nit: Extra space

https://codereview.chromium.org/1841653003/diff/310001/components/omnibox/bro...
File components/omnibox/browser/in_memory_url_index.h (right):

https://codereview.chromium.org/1841653003/diff/310001/components/omnibox/bro...
components/omnibox/browser/in_memory_url_index.h:160: const SchemeSet&
scheme_whitelist);
Nit: All lines of args must be indented the same

https://codereview.chromium.org/1841653003/diff/310001/components/search_engi...
File components/search_engines/template_url.cc (right):

https://codereview.chromium.org/1841653003/diff/310001/components/search_engi...
components/search_engines/template_url.cc:1184: const GURL& url) {
Nit: Rewrap

https://codereview.chromium.org/1841653003/diff/310001/components/url_formatt...
File components/url_formatter/elide_url.cc (right):

https://codereview.chromium.org/1841653003/diff/310001/components/url_formatt...
components/url_formatter/elide_url.cc:129: false /*omit_scheme*/) +
Nit: While here, I'd remove the /*omit_scheme*/ on these two calls and rewrap;
the declaration is just above this so it's not hard for someone to see what that
second arg means, especially now that we have fewer args.

https://codereview.chromium.org/1841653003/diff/310001/components/url_formatt...
File components/url_formatter/elide_url.h (right):

https://codereview.chromium.org/1841653003/diff/310001/components/url_formatt...
components/url_formatter/elide_url.h:30: // formatted, but un-elided, string is
returned. |languages| is a comma
This comment needs updating.

[Yaron, 2016-04-05 03:05:04]

lgtm % Peter's comment in autocomplete_controller_android.cc

[jungshik at Google, 2016-04-05 18:56:19]

Thanks a lot, Peter, for the thorough review. And, thanks Yaron as well.

https://codereview.chromium.org/1841653003/diff/310001/chrome/browser/android...
File chrome/browser/android/omnibox/autocomplete_controller_android.cc (right):

https://codereview.chromium.org/1841653003/diff/310001/chrome/browser/android...
chrome/browser/android/omnibox/autocomplete_controller_android.cc:559:
base::string16 AutocompleteControllerAndroid::FormatURLUsingAcceptLanguages(
On 2016/04/05 02:42:32, Peter Kasting wrote:
> This function name is now inaccurate.

Thanks for catching it. 
Turned out that nobody calls it. (I found that earlier, but forgot later).  I
deleted it (h/cc).

https://codereview.chromium.org/1841653003/diff/310001/components/omnibox/bro...
File components/omnibox/browser/bookmark_provider.cc (right):

https://codereview.chromium.org/1841653003/diff/310001/components/omnibox/bro...
components/omnibox/browser/bookmark_provider.cc:60: bookmark_model_(nullptr) {
On 2016/04/05 02:42:32, Peter Kasting wrote:
> Nit: Eliminates need for function body:
> 
>       bookmark_model_(client ? client ->GetBookmarkModel() : nullptr) {

Done.

https://codereview.chromium.org/1841653003/diff/310001/components/omnibox/bro...
File components/omnibox/browser/history_quick_provider.cc (right):

https://codereview.chromium.org/1841653003/diff/310001/components/omnibox/bro...
components/omnibox/browser/history_quick_provider.cc:245:
client()->GetTemplateURLService());
On 2016/04/05 02:42:32, Peter Kasting wrote:
> Nit: All lines of args must be indented the same

Done.

https://codereview.chromium.org/1841653003/diff/310001/components/omnibox/bro...
File components/omnibox/browser/history_url_provider.cc (right):

https://codereview.chromium.org/1841653003/diff/310001/components/omnibox/bro...
components/omnibox/browser/history_url_provider.cc:1136: MatchType match_type,
On 2016/04/05 02:42:32, Peter Kasting wrote:
> This parameter is no longer needed.

Done.

https://codereview.chromium.org/1841653003/diff/310001/components/omnibox/bro...
File components/omnibox/browser/in_memory_url_index.cc (right):

https://codereview.chromium.org/1841653003/diff/310001/components/omnibox/bro...
components/omnibox/browser/in_memory_url_index.cc:280: this, 
scheme_whitelist_)),
On 2016/04/05 02:42:32, Peter Kasting wrote:
> Nit: Extra space

Done.

https://codereview.chromium.org/1841653003/diff/310001/components/omnibox/bro...
File components/omnibox/browser/in_memory_url_index.h (right):

https://codereview.chromium.org/1841653003/diff/310001/components/omnibox/bro...
components/omnibox/browser/in_memory_url_index.h:160: const SchemeSet&
scheme_whitelist);
On 2016/04/05 02:42:32, Peter Kasting wrote:
> Nit: All lines of args must be indented the same

Done.

https://codereview.chromium.org/1841653003/diff/310001/components/search_engi...
File components/search_engines/template_url.cc (right):

https://codereview.chromium.org/1841653003/diff/310001/components/search_engi...
components/search_engines/template_url.cc:1184: const GURL& url) {
On 2016/04/05 02:42:33, Peter Kasting wrote:
> Nit: Rewrap

Done.

https://codereview.chromium.org/1841653003/diff/310001/components/url_formatt...
File components/url_formatter/elide_url.cc (right):

https://codereview.chromium.org/1841653003/diff/310001/components/url_formatt...
components/url_formatter/elide_url.cc:129: false /*omit_scheme*/) +
On 2016/04/05 02:42:33, Peter Kasting wrote:
> Nit: While here, I'd remove the /*omit_scheme*/ on these two calls and rewrap;
> the declaration is just above this so it's not hard for someone to see what
that
> second arg means, especially now that we have fewer args.

Done.

https://codereview.chromium.org/1841653003/diff/310001/components/url_formatt...
File components/url_formatter/elide_url.h (right):

https://codereview.chromium.org/1841653003/diff/310001/components/url_formatt...
components/url_formatter/elide_url.h:30: // formatted, but un-elided, string is
returned. |languages| is a comma
On 2016/04/05 02:42:33, Peter Kasting wrote:
> This comment needs updating.

oops. Thanks. Done

[jungshik at Google, 2016-04-05 18:57:00]

The CQ bit was checked by jshin@chromium.org

[jungshik at Google, 2016-04-05 18:57:02]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org,
pkasting@chromium.org, torne@chromium.org, esprehn@chromium.org,
yfriedman@chromium.org, sdefresne@chromium.org, fsamuel@chromium.org,
jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1841653003/#ps330001
(title: "address review comments")

[commit-bot: I haz the power, 2016-04-05 18:57:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1841653003/330001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1841653003/330001

[commit-bot: I haz the power, 2016-04-05 19:28:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 19:28:10]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[jungshik at Google, 2016-04-05 19:41:40]

The CQ bit was checked by jshin@chromium.org

[jungshik at Google, 2016-04-05 19:41:41]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org,
pkasting@chromium.org, torne@chromium.org, esprehn@chromium.org,
yfriedman@chromium.org, sdefresne@chromium.org, fsamuel@chromium.org,
jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1841653003/#ps350001
(title: "fix typo in elide_url.cc")

[commit-bot: I haz the power, 2016-04-05 19:42:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1841653003/350001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1841653003/350001

[commit-bot: I haz the power, 2016-04-05 22:13:16]

Committed patchset #19 (id:350001)

[commit-bot: I haz the power, 2016-04-05 22:14:29]

Description was changed from

==========
Drop |languages| from FormatUrl*() and ElideUrl()


In http://crrev.com/382029, IDN display policy was revised to be
independent of Accept-Languages (A-L).  Therefore, IDNToUnicode(), FormatUrl*()
and ElideUrl() do not need |languages| argument any more.
( ElideUrl() can pass A-L down to gfx string drawing/measuring API help
their font selection, but there's no gfx string drawing/measuring API taking
into account A-L values in the font selection atm.)

Drop it in the API and fix all the call sites. There is a huge ripple effect
and a lot of files have to be fixed up.

BUG=336973
TEST=Builds on all platforms and pass all the tests pass
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel
==========

to

==========
Drop |languages| from FormatUrl*() and ElideUrl()

In http://crrev.com/382029, IDN display policy was revised to be
independent of Accept-Languages (A-L).  Therefore, IDNToUnicode(), FormatUrl*()
and ElideUrl() do not need |languages| argument any more.
( ElideUrl() can pass A-L down to gfx string drawing/measuring API help
their font selection, but there's no gfx string drawing/measuring API taking
into account A-L values in the font selection atm.)

Drop it in the API and fix all the call sites. There is a huge ripple effect
and a lot of files have to be fixed up.

BUG=336973
TEST=Builds on all platforms and pass all the tests pass
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel

Committed: https://crrev.com/1fb76469391f6e7e2a846c27a095d57b54b50738
Cr-Commit-Position: refs/heads/master@{#385299}
==========

[commit-bot: I haz the power, 2016-04-05 22:14:32]

Patchset 19 (id:??) landed as
https://crrev.com/1fb76469391f6e7e2a846c27a095d57b54b50738
Cr-Commit-Position: refs/heads/master@{#385299}