Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: components/omnibox/browser/in_memory_url_index.h

Issue 1841653003: Drop |languages| from {Format,Elide}Url* and IDNToUnicode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix typo in elide_url.cc Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/browser/in_memory_url_index.h
diff --git a/components/omnibox/browser/in_memory_url_index.h b/components/omnibox/browser/in_memory_url_index.h
index 1f098cbfedd36d1146416ed6e8146c8071b3a103..3b0fa4175196156b107e88f4bfe1cb4e48103c01 100644
--- a/components/omnibox/browser/in_memory_url_index.h
+++ b/components/omnibox/browser/in_memory_url_index.h
@@ -103,15 +103,12 @@ class InMemoryURLIndex : public KeyedService,
// |history_service| which may be null during unit testing is used to register
// |as an HistoryServiceObserver. |history_dir| is a path to the directory
// containing the history database within the profile wherein the cache and
- // transaction journals will be stored. |languages| gives a list of language
- // encodings by which URLs and omnibox searches are broken down into words and
- // characters.
+ // transaction journals will be stored.
InMemoryURLIndex(bookmarks::BookmarkModel* bookmark_model,
history::HistoryService* history_service,
TemplateURLService* template_url_service,
base::SequencedWorkerPool* worker_pool,
const base::FilePath& history_dir,
- const std::string& languages,
const SchemeSet& client_schemes_to_whitelist);
~InMemoryURLIndex() override;
@@ -160,9 +157,7 @@ class InMemoryURLIndex : public KeyedService,
class RebuildPrivateDataFromHistoryDBTask : public history::HistoryDBTask {
public:
explicit RebuildPrivateDataFromHistoryDBTask(
- InMemoryURLIndex* index,
- const std::string& languages,
- const SchemeSet& scheme_whitelist);
+ InMemoryURLIndex* index, const SchemeSet& scheme_whitelist);
bool RunOnDBThread(history::HistoryBackend* backend,
history::HistoryDatabase* db) override;
@@ -172,7 +167,6 @@ class InMemoryURLIndex : public KeyedService,
~RebuildPrivateDataFromHistoryDBTask() override;
InMemoryURLIndex* index_; // Call back to this index at completion.
- std::string languages_; // Languages for word-breaking.
SchemeSet scheme_whitelist_; // Schemes to be indexed.
bool succeeded_; // Indicates if the rebuild was successful.
scoped_refptr<URLIndexPrivateData> data_; // The rebuilt private data.
@@ -289,9 +283,6 @@ class InMemoryURLIndex : public KeyedService,
// be empty.
base::FilePath history_dir_;
- // Languages used during the word-breaking process during indexing.
- std::string languages_;
-
// Only URLs with a whitelisted scheme are indexed.
SchemeSet scheme_whitelist_;
« no previous file with comments | « components/omnibox/browser/history_url_provider_unittest.cc ('k') | components/omnibox/browser/in_memory_url_index.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698