components/security_interstitials/core/bad_clock_ui.cc - Issue 1841653003: Drop |languages| from {Format,Elide}Url* and IDNToUnicode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/security_interstitials/core/bad_clock_ui.cc

Issue 1841653003: Drop |languages| from {Format,Elide}Url* and IDNToUnicode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix typo in elide_url.cc Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/security_interstitials/core/bad_clock_ui.h ('k') | components/security_interstitials/core/common_string_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/security_interstitials/core/bad_clock_ui.cc

diff --git a/components/security_interstitials/core/bad_clock_ui.cc b/components/security_interstitials/core/bad_clock_ui.cc

index 7debc640b5e3c6ac429121a9f4db123b3f6f681f..59d62d57113b4cc2c04db16bb1657131f0625240 100644

--- a/components/security_interstitials/core/bad_clock_ui.cc

+++ b/components/security_interstitials/core/bad_clock_ui.cc

@@ -17,13 +17,11 @@ BadClockUI::BadClockUI(const GURL& request_url,

const net::SSLInfo& ssl_info,

const base::Time& time_triggered,

ssl_errors::ClockState clock_state,

- const std::string& languages,

ControllerClient* controller)

: request_url_(request_url),

cert_error_(cert_error),

ssl_info_(ssl_info),

time_triggered_(time_triggered),

- languages_(languages),

controller_(controller),

clock_state_(clock_state) {

controller_->metrics_helper()->RecordUserInteraction(

@@ -74,7 +72,7 @@ void BadClockUI::PopulateClockStrings(base::DictionaryValue* load_time_data) {

"primaryParagraph",

l10n_util::GetStringFUTF16(

IDS_CLOCK_ERROR_PRIMARY_PARAGRAPH,

- common_string_util::GetFormattedHostName(request_url_, languages_),

+ common_string_util::GetFormattedHostName(request_url_),

base::TimeFormatFriendlyDateAndTime(time_triggered_)));

load_time_data->SetString(

"primaryButtonText",