Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

Issue 1841653003: Drop |languages| from {Format,Elide}Url* and IDNToUnicode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix typo in elide_url.cc Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
index 732198d3d8cd3292137a713c271fafa4fc65b65b..0e60432e3fc7bb0a5c6f43d0cb78a58233b12c6c 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
+++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
@@ -275,7 +275,7 @@ class BookmarkButton : public BookmarkButtonBase {
gfx::Point location(p);
ConvertPointToScreen(this, &location);
*tooltip = BookmarkBarView::CreateToolTipForURLAndTitle(
- GetWidget(), location, url_, GetText(), profile_);
+ GetWidget(), location, url_, GetText());
return !tooltip->empty();
}
@@ -769,8 +769,7 @@ base::string16 BookmarkBarView::CreateToolTipForURLAndTitle(
const views::Widget* widget,
const gfx::Point& screen_loc,
const GURL& url,
- const base::string16& title,
- Profile* profile) {
+ const base::string16& title) {
const views::TooltipManager* tooltip_manager = widget->GetTooltipManager();
int max_width = tooltip_manager->GetMaxWidth(screen_loc);
const gfx::FontList tt_fonts = tooltip_manager->GetFontList();
@@ -795,10 +794,8 @@ base::string16 BookmarkBarView::CreateToolTipForURLAndTitle(
// "/http://www.yahoo.com" when rendered, as is, in an RTL context since
// the Unicode BiDi algorithm puts certain characters on the left by
// default.
- std::string languages = profile->GetPrefs()->GetString(
- prefs::kAcceptLanguages);
base::string16 elided_url(
- url_formatter::ElideUrl(url, tt_fonts, max_width, languages));
+ url_formatter::ElideUrl(url, tt_fonts, max_width));
elided_url = base::i18n::GetDisplayStringInLTRDirectionality(elided_url);
result.append(elided_url);
}
« no previous file with comments | « chrome/browser/ui/views/bookmarks/bookmark_bar_view.h ('k') | chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698