chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc - Issue 1841653003: Drop |languages| from {Format,Elide}Url* and IDNToUnicode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc

Issue 1841653003: Drop |languages| from {Format,Elide}Url* and IDNToUnicode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix typo in elide_url.cc Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc ('k') | chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc

index 701caca4ec8d9a210d02b455c1345eede063f60b..14a236c823a46dfb800efb36872325eb201be01b 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc

+++ b/chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc

@@ -20,7 +20,6 @@

#include "components/bookmarks/browser/bookmark_utils.h"

#include "components/constrained_window/constrained_window_views.h"

#include "components/history/core/browser/history_service.h"

-#include "components/prefs/pref_service.h"

#include "components/url_formatter/url_fixer.h"

#include "components/user_prefs/user_prefs.h"

#include "grit/components_strings.h"

@@ -377,9 +376,7 @@ void BookmarkEditorView::Init() {

l10n_util::GetStringUTF16(IDS_BOOKMARK_EDITOR_URL_LABEL));

url_tf_ = new views::Textfield;

- PrefService* prefs =

- profile_ ? user_prefs::UserPrefs::Get(profile_) : NULL;

- url_tf_->SetText(chrome::FormatBookmarkURLForDisplay(url, prefs));

+ url_tf_->SetText(chrome::FormatBookmarkURLForDisplay(url));

url_tf_->set_controller(this);

url_tf_->SetAccessibleName(

l10n_util::GetStringUTF16(IDS_BOOKMARK_AX_EDITOR_URL_LABEL));