Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Unified Diff: chrome/browser/push_messaging/push_messaging_notification_manager.cc

Issue 1841653003: Drop |languages| from {Format,Elide}Url* and IDNToUnicode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix typo in elide_url.cc Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/push_messaging/push_messaging_notification_manager.cc
diff --git a/chrome/browser/push_messaging/push_messaging_notification_manager.cc b/chrome/browser/push_messaging/push_messaging_notification_manager.cc
index 40db513ff68c350ced42d8e0f21dca4bd0c6dbbc..d7bcfe4439fee1ee6c4157879c44ec864577bd7b 100644
--- a/chrome/browser/push_messaging/push_messaging_notification_manager.cc
+++ b/chrome/browser/push_messaging/push_messaging_notification_manager.cc
@@ -15,9 +15,7 @@
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/push_messaging/push_messaging_constants.h"
#include "chrome/common/features.h"
-#include "chrome/common/pref_names.h"
#include "chrome/grit/generated_resources.h"
-#include "components/prefs/pref_service.h"
#include "components/rappor/rappor_utils.h"
#include "components/url_formatter/elide_url.h"
#include "content/public/browser/browser_context.h"
@@ -65,11 +63,10 @@ content::StoragePartition* GetStoragePartition(Profile* profile,
NotificationDatabaseData CreateDatabaseData(
const GURL& origin,
- int64_t service_worker_registration_id,
- const std::string& languages) {
+ int64_t service_worker_registration_id) {
PlatformNotificationData notification_data;
notification_data.title =
- url_formatter::FormatUrlForSecurityDisplayOmitScheme(origin, languages);
+ url_formatter::FormatUrlForSecurityDisplayOmitScheme(origin);
notification_data.direction =
PlatformNotificationData::DIRECTION_LEFT_TO_RIGHT;
notification_data.body =
@@ -299,9 +296,8 @@ void PushMessagingNotificationManager::DidGetNotificationsShownAndNeeded(
// The site failed to show a notification when one was needed, and they have
// already failed once in the previous 10 push messages, so we will show a
// generic notification. See https://crbug.com/437277.
- NotificationDatabaseData database_data = CreateDatabaseData(
- origin, service_worker_registration_id,
- profile_->GetPrefs()->GetString(prefs::kAcceptLanguages));
+ NotificationDatabaseData database_data =
+ CreateDatabaseData(origin, service_worker_registration_id);
scoped_refptr<PlatformNotificationContext> notification_context =
GetStoragePartition(profile_, origin)->GetPlatformNotificationContext();
BrowserThread::PostTask(

Powered by Google App Engine
This is Rietveld 408576698