chrome/browser/ui/passwords/password_manager_presenter_unittest.cc - Issue 1841653003: Drop |languages| from {Format,Elide}Url* and IDNToUnicode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/password_manager_presenter_unittest.cc

Issue 1841653003: Drop |languages| from {Format,Elide}Url* and IDNToUnicode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix typo in elide_url.cc Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/password_manager_presenter.cc ('k') | chrome/browser/ui/search_engines/search_engine_tab_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/password_manager_presenter_unittest.cc

diff --git a/chrome/browser/ui/passwords/password_manager_presenter_unittest.cc b/chrome/browser/ui/passwords/password_manager_presenter_unittest.cc

index 5bfb379d2c68b1bc49267b2a29894b6f7c5ad2b5..bc0fe2ba22e48ec6edc0e595773e2c8950aee2dd 100644

--- a/chrome/browser/ui/passwords/password_manager_presenter_unittest.cc

+++ b/chrome/browser/ui/passwords/password_manager_presenter_unittest.cc

@@ -147,9 +147,8 @@ void PasswordManagerPresenterTest::SortAndCheckPositions(

}

DuplicatesMap duplicates;

- std::string languages;

mock_controller_->GetPasswordManagerPresenter()->SortEntriesAndHideDuplicates(

- languages, &list, &duplicates, username_and_password_in_key);

+ &list, &duplicates, username_and_password_in_key);

ASSERT_EQ(expected_number_of_unique_entries, list.size());

ASSERT_EQ(number_of_entries - expected_number_of_unique_entries,