Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_view_utils.cc

Issue 1841653003: Drop |languages| from {Format,Elide}Url* and IDNToUnicode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix typo in elide_url.cc Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/login/login_handler.cc ('k') | chrome/browser/ui/passwords/password_manager_presenter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/passwords/manage_passwords_view_utils.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_view_utils.cc b/chrome/browser/ui/passwords/manage_passwords_view_utils.cc
index 093382d1470c8abab686c6f852073e84c9633500..4ae0e256cc117c8e6d70cb500748ea52fa8ca75b 100644
--- a/chrome/browser/ui/passwords/manage_passwords_view_utils.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_view_utils.cc
@@ -103,8 +103,8 @@ void GetSavePasswordDialogTitleTextAndLinkRange(
: IDS_SAVE_PASSWORD_DIFFERENT_DOMAINS_TITLE;
// TODO(palmer): Look into passing real language prefs here, not "".
// crbug.com/498069.
- replacements.push_back(url_formatter::FormatUrlForSecurityDisplay(
- form_origin_url, std::string()));
+ replacements.push_back(
+ url_formatter::FormatUrlForSecurityDisplay(form_origin_url));
}
if (is_smartlock_branding_enabled) {
@@ -131,9 +131,8 @@ void GetManagePasswordsDialogTitleText(const GURL& user_visible_url,
// (i.e. the one seen in the omnibox) and the managed password origin URL
// differ or not.
if (!SameDomainOrHost(user_visible_url, password_origin_url)) {
- // TODO(palmer): Look into passing real language prefs here, not "".
- base::string16 formatted_url = url_formatter::FormatUrlForSecurityDisplay(
- password_origin_url, std::string());
+ base::string16 formatted_url =
+ url_formatter::FormatUrlForSecurityDisplay(password_origin_url);
*title = l10n_util::GetStringFUTF16(
IDS_MANAGE_PASSWORDS_TITLE_DIFFERENT_DOMAIN, formatted_url);
} else {
« no previous file with comments | « chrome/browser/ui/login/login_handler.cc ('k') | chrome/browser/ui/passwords/password_manager_presenter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698