Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Unified Diff: components/password_manager/core/browser/password_ui_utils_unittest.cc

Issue 1841653003: Drop |languages| from {Format,Elide}Url* and IDNToUnicode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix typo in elide_url.cc Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_ui_utils_unittest.cc
diff --git a/components/password_manager/core/browser/password_ui_utils_unittest.cc b/components/password_manager/core/browser/password_ui_utils_unittest.cc
index 2d7bdddf70636caa1979cb3a57577e8bd41a2f7f..780fa8c50e468c9fde8c98658af768d3efbd845c 100644
--- a/components/password_manager/core/browser/password_ui_utils_unittest.cc
+++ b/components/password_manager/core/browser/password_ui_utils_unittest.cc
@@ -32,8 +32,7 @@ TEST(GetShownOriginTest, RemovePrefixes) {
for (const auto& test_case : kTestCases) {
autofill::PasswordForm password_form;
password_form.origin = GURL(test_case.input);
- EXPECT_EQ(test_case.output,
- GetShownOrigin(password_form.origin, std::string()))
+ EXPECT_EQ(test_case.output, GetShownOrigin(password_form.origin))
<< "for input " << test_case.input;
}
}
@@ -50,10 +49,9 @@ TEST(GetShownOriginAndLinkUrlTest, OriginFromAndroidForm_NoAffiliatedRealm) {
bool is_android_uri;
GURL link_url;
bool origin_is_clickable;
- EXPECT_EQ(
- "android://com.example.android",
- GetShownOriginAndLinkUrl(android_form, std::string(), &is_android_uri,
- &link_url, &origin_is_clickable));
+ EXPECT_EQ("android://com.example.android",
+ GetShownOriginAndLinkUrl(android_form, &is_android_uri, &link_url,
+ &origin_is_clickable));
EXPECT_TRUE(is_android_uri);
EXPECT_FALSE(origin_is_clickable);
EXPECT_EQ(GURL(android_form.signon_realm), link_url);
@@ -71,9 +69,9 @@ TEST(GetShownOriginAndLinkUrlTest, OriginFromAndroidForm_WithAffiliatedRealm) {
bool is_android_uri;
GURL link_url;
bool origin_is_clickable;
- EXPECT_EQ("example.com", GetShownOriginAndLinkUrl(android_form, std::string(),
- &is_android_uri, &link_url,
- &origin_is_clickable));
+ EXPECT_EQ("example.com",
+ GetShownOriginAndLinkUrl(android_form, &is_android_uri, &link_url,
+ &origin_is_clickable));
EXPECT_TRUE(is_android_uri);
EXPECT_TRUE(origin_is_clickable);
EXPECT_EQ(GURL(android_form.affiliated_web_realm), link_url);
@@ -88,8 +86,8 @@ TEST(GetShownOriginAndLinkUrlTest, OriginFromNonAndroidForm) {
GURL link_url;
bool origin_is_clickable;
EXPECT_EQ("example.com",
- GetShownOriginAndLinkUrl(form, std::string(), &is_android_uri,
- &link_url, &origin_is_clickable));
+ GetShownOriginAndLinkUrl(form, &is_android_uri, &link_url,
+ &origin_is_clickable));
EXPECT_FALSE(is_android_uri);
EXPECT_TRUE(origin_is_clickable);
EXPECT_EQ(form.origin, link_url);
« no previous file with comments | « components/password_manager/core/browser/password_ui_utils.cc ('k') | components/search_engines/keyword_table.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698