components/app_modal/javascript_dialog_manager.h - Issue 1841653003: Drop |languages| from {Format,Elide}Url* and IDNToUnicode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/app_modal/javascript_dialog_manager.h

Issue 1841653003: Drop |languages| from {Format,Elide}Url* and IDNToUnicode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix typo in elide_url.cc Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/app_modal/javascript_dialog_manager.h

diff --git a/components/app_modal/javascript_dialog_manager.h b/components/app_modal/javascript_dialog_manager.h

index 66bfe7c3c5d376b12d5c6df0076e7ed9a61687fb..0a797a579fdfd633cfbaa0af627a103b3be7e85c 100644

--- a/components/app_modal/javascript_dialog_manager.h

+++ b/components/app_modal/javascript_dialog_manager.h

@@ -45,7 +45,6 @@ class JavaScriptDialogManager : public content::JavaScriptDialogManager {

// JavaScriptDialogManager:

void RunJavaScriptDialog(content::WebContents* web_contents,

const GURL& origin_url,

- const std::string& accept_lang,

content::JavaScriptMessageType message_type,

const base::string16& message_text,

const base::string16& default_prompt_text,

@@ -63,7 +62,6 @@ class JavaScriptDialogManager : public content::JavaScriptDialogManager {

base::string16 GetTitle(content::WebContents* web_contents,

const GURL& origin_url,

- const std::string& accept_lang,

bool is_alert);

// Wrapper around OnDialogClosed; logs UMA stats before continuing on.

« no previous file with comments | « chrome/test/base/ui_test_utils.cc ('k') | components/app_modal/javascript_dialog_manager.cc » ('j') | no next file with comments »