chrome/browser/extensions/api/bookmarks/bookmarks_api.cc - Issue 1841653003: Drop |languages| from {Format,Elide}Url* and IDNToUnicode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/bookmarks/bookmarks_api.cc

Issue 1841653003: Drop |languages| from {Format,Elide}Url* and IDNToUnicode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix typo in elide_url.cc Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/engagement/site_engagement_service_unittest.cc ('k') | chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/bookmarks/bookmarks_api.cc

diff --git a/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc b/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc

index a59ad279b3dec4e52323d6ec7a6c5c44079acd67..8dce0acdae802eb5bceb53e7e1c107f7c0c3b474 100644

--- a/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc

+++ b/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc

@@ -519,8 +519,6 @@ bool BookmarksSearchFunction::RunOnReady() {

bookmarks::Search::Params::Create(*args_));

EXTENSION_FUNCTION_VALIDATE(params.get());

- PrefService* prefs = user_prefs::UserPrefs::Get(GetProfile());

- std::string lang = prefs->GetString(prefs::kAcceptLanguages);

std::vector<const BookmarkNode*> nodes;

if (params->query.as_string) {

::bookmarks::QueryFields query;

@@ -530,7 +528,6 @@ bool BookmarksSearchFunction::RunOnReady() {

BookmarkModelFactory::GetForProfile(GetProfile()),

query,

std::numeric_limits<int>::max(),

- lang,

&nodes);

} else {

DCHECK(params->query.as_object);

@@ -549,7 +546,6 @@ bool BookmarksSearchFunction::RunOnReady() {

BookmarkModelFactory::GetForProfile(GetProfile()),

query,

std::numeric_limits<int>::max(),

- lang,

&nodes);

}