chrome/browser/ui/views/status_bubble_views.h - Issue 1841653003: Drop |languages| from {Format,Elide}Url* and IDNToUnicode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/status_bubble_views.h

Issue 1841653003: Drop |languages| from {Format,Elide}Url* and IDNToUnicode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix typo in elide_url.cc Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc ('k') | chrome/browser/ui/views/status_bubble_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/status_bubble_views.h

diff --git a/chrome/browser/ui/views/status_bubble_views.h b/chrome/browser/ui/views/status_bubble_views.h

index 02f069fd47be91f2d97b9b863ed84b6abd91d256..142f31459edf09e30f0f4bc37b9a37ccb4c48a23 100644

--- a/chrome/browser/ui/views/status_bubble_views.h

+++ b/chrome/browser/ui/views/status_bubble_views.h

@@ -55,7 +55,7 @@ class StatusBubbleViews : public StatusBubble {

// Overridden from StatusBubble:

void SetStatus(const base::string16& status) override;

- void SetURL(const GURL& url, const std::string& languages) override;

+ void SetURL(const GURL& url) override;

void Hide() override;

void MouseMoved(const gfx::Point& location, bool left_content) override;

void UpdateDownloadShelfVisibility(bool visible) override;

@@ -106,9 +106,6 @@ class StatusBubbleViews : public StatusBubble {

// The original, non-elided URL.

GURL url_;

- // Used to elide the original URL again when we expand it.

- std::string languages_;

// Position relative to the base_view_.

gfx::Point original_position_;

// original_position_ adjusted according to the current RTL.