chrome/browser/custom_home_pages_table_model.cc - Issue 1841653003: Drop |languages| from {Format,Elide}Url* and IDNToUnicode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/custom_home_pages_table_model.cc

Issue 1841653003: Drop |languages| from {Format,Elide}Url* and IDNToUnicode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix typo in elide_url.cc Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/content_settings/tab_specific_content_settings.cc ('k') | chrome/browser/dom_distiller/tab_utils_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/custom_home_pages_table_model.cc

diff --git a/chrome/browser/custom_home_pages_table_model.cc b/chrome/browser/custom_home_pages_table_model.cc

index dd89679342c54dbe83f0a2b11f200ce330ae6d6f..5c1bc7de851da1ce06a252303f52382ff3c4fb60 100644

--- a/chrome/browser/custom_home_pages_table_model.cc

+++ b/chrome/browser/custom_home_pages_table_model.cc

@@ -16,11 +16,9 @@

#include "chrome/browser/ui/browser_list.h"

#include "chrome/browser/ui/settings_window_manager.h"

#include "chrome/browser/ui/tabs/tab_strip_model.h"

-#include "chrome/common/pref_names.h"

#include "chrome/common/url_constants.h"

#include "chrome/grit/generated_resources.h"

#include "components/history/core/browser/history_service.h"

-#include "components/prefs/pref_service.h"

#include "components/url_formatter/url_formatter.h"

#include "content/public/browser/web_contents.h"

#include "ui/base/l10n/l10n_util.h"

@@ -318,9 +316,7 @@ void CustomHomePagesTableModel::OnGotTitle(const GURL& entry_url,

}

base::string16 CustomHomePagesTableModel::FormattedURL(int row) const {

- std::string languages =

- profile_->GetPrefs()->GetString(prefs::kAcceptLanguages);

- base::string16 url = url_formatter::FormatUrl(entries_[row].url, languages);

+ base::string16 url = url_formatter::FormatUrl(entries_[row].url);

url = base::i18n::GetDisplayStringInLTRDirectionality(url);

return url;

}