Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: components/omnibox/browser/history_url_provider_unittest.cc

Issue 1841653003: Drop |languages| from {Format,Elide}Url* and IDNToUnicode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix typo in elide_url.cc Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/browser/history_url_provider_unittest.cc
diff --git a/components/omnibox/browser/history_url_provider_unittest.cc b/components/omnibox/browser/history_url_provider_unittest.cc
index 00c0b53d0fc6a379ebd7de983b8cb743f456ef64..a28f285ad735b356176b9fa863602ad46035e8b8 100644
--- a/components/omnibox/browser/history_url_provider_unittest.cc
+++ b/components/omnibox/browser/history_url_provider_unittest.cc
@@ -41,8 +41,6 @@ using base::TimeDelta;
namespace {
-const char kDefaultAcceptLanguages[] = "en-US,en,ko";
-
struct TestURLInfo {
const char* url;
const char* title;
@@ -163,7 +161,7 @@ class FakeAutocompleteProviderClient : public MockAutocompleteProviderClient {
make_scoped_ptr(new TemplateURLService(nullptr, 0)));
if (history_dir_.CreateUniqueTempDir()) {
history_service_ = history::CreateHistoryService(
- history_dir_.path(), kDefaultAcceptLanguages, create_history_db);
+ history_dir_.path(), create_history_db);
}
}
@@ -280,8 +278,6 @@ bool HistoryURLProviderTest::SetUpImpl(bool create_history_db) {
client_.reset(new FakeAutocompleteProviderClient(create_history_db));
if (!client_->GetHistoryService())
return false;
- EXPECT_CALL(*client_, GetAcceptLanguages())
- .WillRepeatedly(testing::Return(kDefaultAcceptLanguages));
autocomplete_ = new HistoryURLProvider(client_.get(), this);
FillData();
return true;
@@ -336,10 +332,8 @@ void HistoryURLProviderTest::RunTest(
matches_ = autocomplete_->matches();
if (sort_matches_) {
TemplateURLService* service = client_->GetTemplateURLService();
- for (ACMatches::iterator i = matches_.begin(); i != matches_.end(); ++i) {
- i->ComputeStrippedDestinationURL(
- input, client_->GetAcceptLanguages(), service);
- }
+ for (ACMatches::iterator i = matches_.begin(); i != matches_.end(); ++i)
+ i->ComputeStrippedDestinationURL(input, service);
AutocompleteResult::DedupMatchesByDestination(
input.current_page_classification(), false, &matches_);
std::sort(matches_.begin(), matches_.end(),
« no previous file with comments | « components/omnibox/browser/history_url_provider.cc ('k') | components/omnibox/browser/in_memory_url_index.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698