components/history/core/browser/url_database.cc - Issue 1841653003: Drop |languages| from {Format,Elide}Url* and IDNToUnicode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/history/core/browser/url_database.cc

Issue 1841653003: Drop |languages| from {Format,Elide}Url* and IDNToUnicode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix typo in elide_url.cc Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/history/core/browser/typed_url_syncable_service_unittest.cc ('k') | components/history/core/test/history_backend_db_base_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/history/core/browser/url_database.cc

diff --git a/components/history/core/browser/url_database.cc b/components/history/core/browser/url_database.cc

index 3896ab444dc98e8bfbb51073083fdfbd8e20bb85..3b4cb272584746c8cd09db468ac72f598e16f76d 100644

--- a/components/history/core/browser/url_database.cc

+++ b/components/history/core/browser/url_database.cc

@@ -370,11 +370,8 @@ bool URLDatabase::GetTextMatches(const base::string16& query,

GURL gurl(url);

if (gurl.is_valid()) {

// Decode punycode to match IDN.

- // |query_words| won't be shown to user - therefore we can use empty

- // |languages| to reduce dependency (no need to call PrefService).

base::string16 ascii = base::ASCIIToUTF16(gurl.host());

- base::string16 utf =

- url_formatter::IDNToUnicode(gurl.host(), std::string());

+ base::string16 utf = url_formatter::IDNToUnicode(gurl.host());

if (ascii != utf)

query_parser_.ExtractQueryWords(utf, &query_words);

}