Change SkShader;asFragmentProcessor signature to no longer take skpaint\grcolor*

Change SkShader;asFragmentProcessor signature to no longer take skpaint\grcolor*

Committed: https://skia.googlesource.com/skia/+/ecfdc251be71f3d634e76afdd6375bf55fc061aa

Committed: https://skia.googlesource.com/skia/+/c21b09eec91c9e263cb0b88467ea44e348ed4962

[bsalomon, 2015-08-24 21:28:16]

bsalomon@google.com changed reviewers:
+ joshualitt@google.com, wangyix@google.com

[bsalomon, 2015-08-24 21:28:17]

Not finished and fails some tests but figured I'd pass this along since I'll be
out tomorrow.

[bsalomon, 2015-08-24 21:29:32]

On 2015/08/24 21:28:17, bsalomon wrote:
> Not finished and fails some tests but figured I'd pass this along since I'll
be
> out tomorrow.

Dependent on https://codereview.chromium.org/1307223004

[bsalomon, 2015-08-27 16:31:37]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[bsalomon, 2015-08-27 16:31:38]

This will temporarily break the blending against vertex colors for drawVertices
and drawAtlas. They were using a kind of loophole in the current
asFragmentProcessor() contract to ignore the returned GrColor and pipe in vertex
colors instead. This can be fixed in a follow on CL that adds a processor that
composes an arbitrary processor against the vertex color.

[bsalomon, 2015-08-27 16:31:47]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-08-27 16:31:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1316513002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1316513002/80001

[commit-bot: I haz the power, 2015-08-27 16:32:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-27 16:32:46]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[bsalomon, 2015-08-27 17:32:25]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-08-27 17:32:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1316513002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1316513002/100001

[commit-bot: I haz the power, 2015-08-27 17:33:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-27 17:33:42]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)

[bsalomon, 2015-08-27 17:40:17]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-08-27 17:40:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1316513002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1316513002/120001

[commit-bot: I haz the power, 2015-08-27 17:45:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-27 17:45:42]

Dry run: This issue passed the CQ dry run.

[wangyix, 2015-08-28 15:02:13]

lgtm

https://codereview.chromium.org/1316513002/diff/120001/src/core/SkPictureShad...
File src/core/SkPictureShader.cpp (right):

https://codereview.chromium.org/1316513002/diff/120001/src/core/SkPictureShad...
src/core/SkPictureShader.cpp:350: return
bitmapShader->asFragmentProcessor(context, viewM, NULL, fq, procDataManager);
NULL is passed to asFragmentProcessor() everywhere instead of nullptr.  Is there
a reason for this?

[bsalomon, 2015-08-28 15:08:27]

https://codereview.chromium.org/1316513002/diff/120001/src/core/SkPictureShad...
File src/core/SkPictureShader.cpp (right):

https://codereview.chromium.org/1316513002/diff/120001/src/core/SkPictureShad...
src/core/SkPictureShader.cpp:350: return
bitmapShader->asFragmentProcessor(context, viewM, NULL, fq, procDataManager);
On 2015/08/28 15:02:13, wangyix wrote:
> NULL is passed to asFragmentProcessor() everywhere instead of nullptr.  Is
there
> a reason for this?

Done.

[bsalomon, 2015-08-28 16:03:39]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2015-08-28 16:03:39]

The patchset sent to the CQ was uploaded after l-g-t-m from wangyix@google.com
Link to the patchset: https://codereview.chromium.org/1316513002/#ps140001
(title: "nullptr")

[commit-bot: I haz the power, 2015-08-28 16:03:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1316513002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1316513002/140001

[commit-bot: I haz the power, 2015-08-28 16:03:52]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-08-28 22:03 UTC

[robertphillips, 2015-08-28 21:33:06]

lgtm - a few semi-real issues + a lot of nits

https://codereview.chromium.org/1316513002/diff/140001/gm/dcshader.cpp
File gm/dcshader.cpp (right):

https://codereview.chromium.org/1316513002/diff/140001/gm/dcshader.cpp#newcode37
gm/dcshader.cpp:37: const GrFragmentProcessor* asFragmentProcessor(GrContext*,
const SkMatrix& viewM,
indent ?

https://codereview.chromium.org/1316513002/diff/140001/gm/dcshader.cpp#newcode97
gm/dcshader.cpp:97: const GrFragmentProcessor*
DCShader::asFragmentProcessor(GrContext*, const SkMatrix& viewM,
indent ?

https://codereview.chromium.org/1316513002/diff/140001/include/core/SkShader.h
File include/core/SkShader.h (right):

https://codereview.chromium.org/1316513002/diff/140001/include/core/SkShader....
include/core/SkShader.h:346: virtual const GrFragmentProcessor*
asFragmentProcessor(GrContext*,
viewMatric ?

https://codereview.chromium.org/1316513002/diff/140001/include/gpu/GrFragment...
File include/gpu/GrFragmentProcessor.h (right):

https://codereview.chromium.org/1316513002/diff/140001/include/gpu/GrFragment...
include/gpu/GrFragmentProcessor.h:11: #include "GrProcessor.h"
Do we even need this include ?

https://codereview.chromium.org/1316513002/diff/140001/src/core/SkLightingSha...
File src/core/SkLightingShader.cpp (right):

https://codereview.chromium.org/1316513002/diff/140001/src/core/SkLightingSha...
src/core/SkLightingShader.cpp:76: const GrFragmentProcessor*
asFragmentProcessor(GrContext*, const SkMatrix& viewM,
indent ?

https://codereview.chromium.org/1316513002/diff/140001/src/core/SkLightingSha...
src/core/SkLightingShader.cpp:346: const GrFragmentProcessor*
SkLightingShaderImpl::asFragmentProcessor(GrContext* context,
indent ?

https://codereview.chromium.org/1316513002/diff/140001/src/core/SkPictureShad...
File src/core/SkPictureShader.cpp (right):

https://codereview.chromium.org/1316513002/diff/140001/src/core/SkPictureShad...
src/core/SkPictureShader.cpp:339: const GrFragmentProcessor*
SkPictureShader::asFragmentProcessor(GrContext* context,
tabs ?

https://codereview.chromium.org/1316513002/diff/140001/src/core/SkPictureShad...
File src/core/SkPictureShader.h (right):

https://codereview.chromium.org/1316513002/diff/140001/src/core/SkPictureShad...
src/core/SkPictureShader.h:34: const GrFragmentProcessor*
asFragmentProcessor(GrContext*, const SkMatrix& viewM,
tabs ?

https://codereview.chromium.org/1316513002/diff/140001/src/effects/SkPerlinNo...
File src/effects/SkPerlinNoiseShader.cpp (right):

https://codereview.chromium.org/1316513002/diff/140001/src/effects/SkPerlinNo...
src/effects/SkPerlinNoiseShader.cpp:610: 
Can we delete 'effect' too ?

https://codereview.chromium.org/1316513002/diff/140001/src/effects/SkPerlinNo...
src/effects/SkPerlinNoiseShader.cpp:613: return
shader->asFragmentProcessor(d->fContext,
nullptr ?

https://codereview.chromium.org/1316513002/diff/140001/src/effects/SkPerlinNo...
src/effects/SkPerlinNoiseShader.cpp:617: 
what's up with this cruft ?

https://codereview.chromium.org/1316513002/diff/140001/src/effects/SkPerlinNo...
src/effects/SkPerlinNoiseShader.cpp:921: const GrFragmentProcessor*
SkPerlinNoiseShader::asFragmentProcessor(GrContext* context,
tabs ?

https://codereview.chromium.org/1316513002/diff/140001/src/effects/SkPerlinNo...
src/effects/SkPerlinNoiseShader.cpp:948: 
Make this an auto delete ?

https://codereview.chromium.org/1316513002/diff/140001/src/effects/SkPerlinNo...
src/effects/SkPerlinNoiseShader.cpp:967: m));
Can't paintData get leaked here ?

https://codereview.chromium.org/1316513002/diff/140001/src/effects/gradients/...
File src/effects/gradients/SkLinearGradient.cpp (right):

https://codereview.chromium.org/1316513002/diff/140001/src/effects/gradients/...
src/effects/gradients/SkLinearGradient.cpp:542: const GrFragmentProcessor*
SkLinearGradient::asFragmentProcessor(
tabs ?

https://codereview.chromium.org/1316513002/diff/140001/src/effects/gradients/...
File src/effects/gradients/SkLinearGradient.h (right):

https://codereview.chromium.org/1316513002/diff/140001/src/effects/gradients/...
src/effects/gradients/SkLinearGradient.h:33: const GrFragmentProcessor*
asFragmentProcessor(GrContext*, const SkMatrix& viewM,
tabs ?

https://codereview.chromium.org/1316513002/diff/140001/src/effects/gradients/...
File src/effects/gradients/SkRadialGradient.cpp (right):

https://codereview.chromium.org/1316513002/diff/140001/src/effects/gradients/...
src/effects/gradients/SkRadialGradient.cpp:515: const GrFragmentProcessor*
SkRadialGradient::asFragmentProcessor(GrContext* context,
tabs ?

https://codereview.chromium.org/1316513002/diff/140001/src/effects/gradients/...
File src/effects/gradients/SkRadialGradient.h (right):

https://codereview.chromium.org/1316513002/diff/140001/src/effects/gradients/...
src/effects/gradients/SkRadialGradient.h:33: const GrFragmentProcessor*
asFragmentProcessor(GrContext*, const SkMatrix& viewM,
tabs ?

https://codereview.chromium.org/1316513002/diff/140001/src/effects/gradients/...
File src/effects/gradients/SkSweepGradient.cpp (right):

https://codereview.chromium.org/1316513002/diff/140001/src/effects/gradients/...
src/effects/gradients/SkSweepGradient.cpp:273: const GrFragmentProcessor*
SkSweepGradient::asFragmentProcessor(GrContext* context,
tabs ?

https://codereview.chromium.org/1316513002/diff/140001/src/effects/gradients/...
File src/effects/gradients/SkSweepGradient.h (right):

https://codereview.chromium.org/1316513002/diff/140001/src/effects/gradients/...
src/effects/gradients/SkSweepGradient.h:34: const GrFragmentProcessor*
asFragmentProcessor(GrContext*, const SkMatrix& viewM,
tabs ?

https://codereview.chromium.org/1316513002/diff/140001/src/effects/gradients/...
File src/effects/gradients/SkTwoPointConicalGradient.cpp (right):

https://codereview.chromium.org/1316513002/diff/140001/src/effects/gradients/...
src/effects/gradients/SkTwoPointConicalGradient.cpp:364: const
GrFragmentProcessor* SkTwoPointConicalGradient::asFragmentProcessor(GrContext*
context,
tabs ?

https://codereview.chromium.org/1316513002/diff/140001/src/effects/gradients/...
File src/effects/gradients/SkTwoPointConicalGradient.h (right):

https://codereview.chromium.org/1316513002/diff/140001/src/effects/gradients/...
src/effects/gradients/SkTwoPointConicalGradient.h:63: const GrFragmentProcessor*
asFragmentProcessor(GrContext*, const SkMatrix&, const SkMatrix*,
tabs ?

[commit-bot: I haz the power, 2015-08-28 21:33:52]

Committed patchset #8 (id:140001) as
https://skia.googlesource.com/skia/+/ecfdc251be71f3d634e76afdd6375bf55fc061aa

[rmistry, 2015-08-29 00:16:20]

A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/1313573005/ by rmistry@google.com.

The reason for reverting is: Primary suspect in failing DEPS rolls:
* https://codereview.chromium.org/1315753006
* https://codereview.chromium.org/1308323006
* https://codereview.chromium.org/1320903004

Primary suspect because the failing win bots did not fail in
https://codereview.chromium.org/1315753005.

[bsalomon, 2015-08-29 00:56:54]

On 2015/08/29 00:16:20, rmistry wrote:
> A revert of this CL (patchset #8 id:140001) has been created in
> https://codereview.chromium.org/1313573005/ by mailto:rmistry@google.com.
> 
> The reason for reverting is: Primary suspect in failing DEPS rolls:
> * https://codereview.chromium.org/1315753006
> * https://codereview.chromium.org/1308323006
> * https://codereview.chromium.org/1320903004
> 
> Primary suspect because the failing win bots did not fail in
> https://codereview.chromium.org/1315753005.

Oops... meant to dry run this! Will address Rob's comments, roll failures and
reland

[bsalomon, 2015-08-29 01:41:21]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2015-08-29 01:41:21]

The patchset sent to the CQ was uploaded after l-g-t-m from wangyix@google.com,
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1316513002/#ps160001
(title: "Address comments, fix roll(?)")

[commit-bot: I haz the power, 2015-08-29 01:41:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1316513002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1316513002/160001

[bsalomon, 2015-08-29 01:42:50]

https://codereview.chromium.org/1316513002/diff/140001/gm/dcshader.cpp
File gm/dcshader.cpp (right):

https://codereview.chromium.org/1316513002/diff/140001/gm/dcshader.cpp#newcode37
gm/dcshader.cpp:37: const GrFragmentProcessor* asFragmentProcessor(GrContext*,
const SkMatrix& viewM,
On 2015/08/28 21:33:05, robertphillips wrote:
> indent ?

Done.

https://codereview.chromium.org/1316513002/diff/140001/gm/dcshader.cpp#newcode97
gm/dcshader.cpp:97: const GrFragmentProcessor*
DCShader::asFragmentProcessor(GrContext*, const SkMatrix& viewM,
On 2015/08/28 21:33:05, robertphillips wrote:
> indent ?

Done.

https://codereview.chromium.org/1316513002/diff/140001/include/core/SkShader.h
File include/core/SkShader.h (right):

https://codereview.chromium.org/1316513002/diff/140001/include/core/SkShader....
include/core/SkShader.h:346: virtual const GrFragmentProcessor*
asFragmentProcessor(GrContext*,
On 2015/08/28 21:33:05, robertphillips wrote:
> viewMatric ?

Done.

https://codereview.chromium.org/1316513002/diff/140001/include/gpu/GrFragment...
File include/gpu/GrFragmentProcessor.h (right):

https://codereview.chromium.org/1316513002/diff/140001/include/gpu/GrFragment...
include/gpu/GrFragmentProcessor.h:11: #include "GrProcessor.h"
On 2015/08/28 21:33:05, robertphillips wrote:
> Do we even need this include ?

Done.

https://codereview.chromium.org/1316513002/diff/140001/src/core/SkLightingSha...
File src/core/SkLightingShader.cpp (right):

https://codereview.chromium.org/1316513002/diff/140001/src/core/SkLightingSha...
src/core/SkLightingShader.cpp:76: const GrFragmentProcessor*
asFragmentProcessor(GrContext*, const SkMatrix& viewM,
On 2015/08/28 21:33:05, robertphillips wrote:
> indent ?

Done.

https://codereview.chromium.org/1316513002/diff/140001/src/core/SkLightingSha...
src/core/SkLightingShader.cpp:346: const GrFragmentProcessor*
SkLightingShaderImpl::asFragmentProcessor(GrContext* context,
On 2015/08/28 21:33:05, robertphillips wrote:
> indent ?

Done.

https://codereview.chromium.org/1316513002/diff/140001/src/core/SkPictureShad...
File src/core/SkPictureShader.cpp (right):

https://codereview.chromium.org/1316513002/diff/140001/src/core/SkPictureShad...
src/core/SkPictureShader.cpp:339: const GrFragmentProcessor*
SkPictureShader::asFragmentProcessor(GrContext* context,
On 2015/08/28 21:33:05, robertphillips wrote:
> tabs ?

Done.

https://codereview.chromium.org/1316513002/diff/140001/src/core/SkPictureShad...
File src/core/SkPictureShader.h (right):

https://codereview.chromium.org/1316513002/diff/140001/src/core/SkPictureShad...
src/core/SkPictureShader.h:34: const GrFragmentProcessor*
asFragmentProcessor(GrContext*, const SkMatrix& viewM,
On 2015/08/28 21:33:05, robertphillips wrote:
> tabs ?

Done.

https://codereview.chromium.org/1316513002/diff/140001/src/effects/SkPerlinNo...
File src/effects/SkPerlinNoiseShader.cpp (right):

https://codereview.chromium.org/1316513002/diff/140001/src/effects/SkPerlinNo...
src/effects/SkPerlinNoiseShader.cpp:610: 
On 2015/08/28 21:33:05, robertphillips wrote:
> Can we delete 'effect' too ?

Done.

https://codereview.chromium.org/1316513002/diff/140001/src/effects/SkPerlinNo...
src/effects/SkPerlinNoiseShader.cpp:613: return
shader->asFragmentProcessor(d->fContext,
On 2015/08/28 21:33:05, robertphillips wrote:
> nullptr ?

Done.

https://codereview.chromium.org/1316513002/diff/140001/src/effects/SkPerlinNo...
src/effects/SkPerlinNoiseShader.cpp:617: 
On 2015/08/28 21:33:05, robertphillips wrote:
> what's up with this cruft ?

mismerge, done

https://codereview.chromium.org/1316513002/diff/140001/src/effects/SkPerlinNo...
src/effects/SkPerlinNoiseShader.cpp:921: const GrFragmentProcessor*
SkPerlinNoiseShader::asFragmentProcessor(GrContext* context,
On 2015/08/28 21:33:05, robertphillips wrote:
> tabs ?

Done.

https://codereview.chromium.org/1316513002/diff/140001/src/effects/SkPerlinNo...
src/effects/SkPerlinNoiseShader.cpp:948: 
On 2015/08/28 21:33:05, robertphillips wrote:
> Make this an auto delete ?

looks like GrPerlinNoiseEffect takes ownership of this data and deletes it  in
its ~

https://codereview.chromium.org/1316513002/diff/140001/src/effects/SkPerlinNo...
src/effects/SkPerlinNoiseShader.cpp:967: m));
On 2015/08/28 21:33:05, robertphillips wrote:
> Can't paintData get leaked here ?

see above

https://codereview.chromium.org/1316513002/diff/140001/src/effects/gradients/...
File src/effects/gradients/SkLinearGradient.cpp (right):

https://codereview.chromium.org/1316513002/diff/140001/src/effects/gradients/...
src/effects/gradients/SkLinearGradient.cpp:542: const GrFragmentProcessor*
SkLinearGradient::asFragmentProcessor(
On 2015/08/28 21:33:05, robertphillips wrote:
> tabs ?

Done.

https://codereview.chromium.org/1316513002/diff/140001/src/effects/gradients/...
File src/effects/gradients/SkLinearGradient.h (right):

https://codereview.chromium.org/1316513002/diff/140001/src/effects/gradients/...
src/effects/gradients/SkLinearGradient.h:33: const GrFragmentProcessor*
asFragmentProcessor(GrContext*, const SkMatrix& viewM,
On 2015/08/28 21:33:06, robertphillips wrote:
> tabs ?

Done.

https://codereview.chromium.org/1316513002/diff/140001/src/effects/gradients/...
File src/effects/gradients/SkRadialGradient.cpp (right):

https://codereview.chromium.org/1316513002/diff/140001/src/effects/gradients/...
src/effects/gradients/SkRadialGradient.cpp:515: const GrFragmentProcessor*
SkRadialGradient::asFragmentProcessor(GrContext* context,
On 2015/08/28 21:33:06, robertphillips wrote:
> tabs ?

Done.

https://codereview.chromium.org/1316513002/diff/140001/src/effects/gradients/...
File src/effects/gradients/SkRadialGradient.h (right):

https://codereview.chromium.org/1316513002/diff/140001/src/effects/gradients/...
src/effects/gradients/SkRadialGradient.h:33: const GrFragmentProcessor*
asFragmentProcessor(GrContext*, const SkMatrix& viewM,
On 2015/08/28 21:33:06, robertphillips wrote:
> tabs ?

Done.

https://codereview.chromium.org/1316513002/diff/140001/src/effects/gradients/...
File src/effects/gradients/SkSweepGradient.cpp (right):

https://codereview.chromium.org/1316513002/diff/140001/src/effects/gradients/...
src/effects/gradients/SkSweepGradient.cpp:273: const GrFragmentProcessor*
SkSweepGradient::asFragmentProcessor(GrContext* context,
On 2015/08/28 21:33:06, robertphillips wrote:
> tabs ?

Done.

https://codereview.chromium.org/1316513002/diff/140001/src/effects/gradients/...
File src/effects/gradients/SkSweepGradient.h (right):

https://codereview.chromium.org/1316513002/diff/140001/src/effects/gradients/...
src/effects/gradients/SkSweepGradient.h:34: const GrFragmentProcessor*
asFragmentProcessor(GrContext*, const SkMatrix& viewM,
On 2015/08/28 21:33:06, robertphillips wrote:
> tabs ?

Done.

https://codereview.chromium.org/1316513002/diff/140001/src/effects/gradients/...
File src/effects/gradients/SkTwoPointConicalGradient.cpp (right):

https://codereview.chromium.org/1316513002/diff/140001/src/effects/gradients/...
src/effects/gradients/SkTwoPointConicalGradient.cpp:364: const
GrFragmentProcessor* SkTwoPointConicalGradient::asFragmentProcessor(GrContext*
context,
On 2015/08/28 21:33:06, robertphillips wrote:
> tabs ?

Done.

https://codereview.chromium.org/1316513002/diff/140001/src/effects/gradients/...
File src/effects/gradients/SkTwoPointConicalGradient.h (right):

https://codereview.chromium.org/1316513002/diff/140001/src/effects/gradients/...
src/effects/gradients/SkTwoPointConicalGradient.h:63: const GrFragmentProcessor*
asFragmentProcessor(GrContext*, const SkMatrix&, const SkMatrix*,
On 2015/08/28 21:33:06, robertphillips wrote:
> tabs ?

Done.

[commit-bot: I haz the power, 2015-08-29 01:47:00]

Committed patchset #9 (id:160001) as
https://skia.googlesource.com/skia/+/c21b09eec91c9e263cb0b88467ea44e348ed4962