Change SkShader;asFragmentProcessor signature to no longer take skpaint\grcolor*

src/core/SkPictureShader.cpp

 /*
  * Copyright 2014 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkPictureShader.h"
 
 #include "SkBitmap.h"
@@ skipping 318 matching lines @@
                  fPicture ? fPicture->cullRect().fRight : 0,
                  fPicture ? fPicture->cullRect().fBottom : 0);
 
     str->appendf("(%s, %s)", gTileModeName[fTmx], gTileModeName[fTmy]);
 
     this->INHERITED::toString(str);
 }
 #endif
 
 #if SK_SUPPORT_GPU
-bool SkPictureShader::asFragmentProcessor(GrContext* context, const SkPaint& paint,
-                                          const SkMatrix& viewM, const SkMatrix* localMatrix,
-                                          GrColor* paintColor,
-                                          GrProcessorDataManager* procDataManager,
-                                          GrFragmentProcessor** fp) const {
+const GrFragmentProcessor* SkPictureShader::asFragmentProcessor(GrContext* context,
+    const SkMatrix& viewM, const SkMatrix* localMatrix, SkFilterQuality fq,
+    GrProcessorDataManager* procDataManager) const {
     int maxTextureSize = 0;
     if (context) {
         maxTextureSize = context->caps()->maxTextureSize();
     }
     SkAutoTUnref<SkShader> bitmapShader(this->refBitmapShader(viewM, localMatrix, maxTextureSize));
     if (!bitmapShader) {
-        return false;
+        return nullptr;
     }
-    return bitmapShader->asFragmentProcessor(context, paint, viewM, nullptr, paintColor,
-                                             procDataManager, fp);
-}
-#else
-bool SkPictureShader::asFragmentProcessor(GrContext*, const SkPaint&, const SkMatrix&,
-                                          const SkMatrix*, GrColor*, GrProcessorDataManager*,
-                                          GrFragmentProcessor**) const {
-    SkDEBUGFAIL("Should not call in GPU-less build");
-    return false;
+    return bitmapShader->asFragmentProcessor(context, viewM, NULL, fq, procDataManager);

[wangyix, 2015/08/28 15:02:13]

NULL is passed to asFragmentProcessor() everywhere instead of nullptr.  Is there
a reason for this?

[bsalomon, 2015/08/28 15:08:27]

Done.

 }
 #endif