src/gpu/effects/GrCoverageSetOpXP.cpp - Issue 1316513002: Change SkShader;asFragmentProcessor signature to no longer take skpaint\grcolor*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/effects/GrCoverageSetOpXP.cpp

Issue 1316513002: Change SkShader;asFragmentProcessor signature to no longer take skpaint\grcolor* (Closed) Base URL: https://skia.googlesource.com/skia.git@things

Patch Set: Address comments, fix roll(?) Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/gpu/effects/GrCoverageSetOpXP.cpp

diff --git a/src/gpu/effects/GrCoverageSetOpXP.cpp b/src/gpu/effects/GrCoverageSetOpXP.cpp

index 8c45d22727ab18a28dfaf95d818ab5217dbc8287..89d7565894a9a4f33f5e83edca46aa247432a9c8 100644

--- a/src/gpu/effects/GrCoverageSetOpXP.cpp

+++ b/src/gpu/effects/GrCoverageSetOpXP.cpp

@@ -245,7 +245,7 @@ void GrCoverageSetOpXPFactory::getInvariantBlendedColor(const GrProcOptInfo& col

GR_DEFINE_XP_FACTORY_TEST(GrCoverageSetOpXPFactory);

-GrXPFactory* GrCoverageSetOpXPFactory::TestCreate(GrProcessorTestData* d) {

+const GrXPFactory* GrCoverageSetOpXPFactory::TestCreate(GrProcessorTestData* d) {

SkRegion::Op regionOp = SkRegion::Op(d->fRandom->nextULessThan(SkRegion::kLastOp + 1));

bool invertCoverage = d->fRandom->nextBool();

return GrCoverageSetOpXPFactory::Create(regionOp, invertCoverage);

« no previous file with comments | « src/gpu/effects/GrConvolutionEffect.cpp ('k') | src/gpu/effects/GrCustomXfermode.cpp » ('j') | no next file with comments »