Remove GrStagedProcessor, remove the word Stage as it applies to FPs

Remove GrStagedProcessor, remove the word Stage as it applies to FPs

Committed: https://skia.googlesource.com/skia/+/24243446cdf7b7e4e132c2a0c387c7723777e0c7

Committed: https://skia.googlesource.com/skia/+/ac856c97acc84dcb54d9cdb068ec8a02b8869647

[bsalomon, 2015-08-24 17:37:13]

bsalomon@google.com changed reviewers:
+ joshualitt@google.com

[bsalomon, 2015-08-24 17:37:22]

bsalomon@google.com changed reviewers:
+ egdaniel@google.com

[egdaniel, 2015-08-25 13:30:51]

lgtm

[bsalomon, 2015-08-26 12:33:24]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2015-08-26 12:33:25]

The patchset sent to the CQ was uploaded after l-g-t-m from egdaniel@google.com
Link to the patchset: https://codereview.chromium.org/1307223004/#ps90001
(title: "rebase")

[commit-bot: I haz the power, 2015-08-26 12:33:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1307223004/90001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1307223004/90001

[commit-bot: I haz the power, 2015-08-26 12:39:21]

Committed patchset #6 (id:90001) as
https://skia.googlesource.com/skia/+/24243446cdf7b7e4e132c2a0c387c7723777e0c7

[rmistry, 2015-08-26 13:48:13]

A revert of this CL (patchset #6 id:90001) has been created in
https://codereview.chromium.org/1306803003/ by rmistry@google.com.

The reason for reverting is: Causes bot failures:

https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Mac10.9-Clan...

https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-S...

https://uberchromegw.corp.google.com/i/client.skia.android/builders/Test-Andr....

[bsalomon, 2015-08-26 20:56:27]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2015-08-26 20:56:28]

The patchset sent to the CQ was uploaded after l-g-t-m from egdaniel@google.com
Link to the patchset: https://codereview.chromium.org/1307223004/#ps110001
(title: "fix paint copy cons")

[commit-bot: I haz the power, 2015-08-26 20:56:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1307223004/110001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1307223004/110001

[commit-bot: I haz the power, 2015-08-26 20:57:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-26 20:57:44]

Try jobs failed on following builders:
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[bsalomon, 2015-08-26 21:00:58]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2015-08-26 21:00:58]

The patchset sent to the CQ was uploaded after l-g-t-m from egdaniel@google.com
Link to the patchset: https://codereview.chromium.org/1307223004/#ps130001
(title: "rebase")

[commit-bot: I haz the power, 2015-08-26 21:01:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1307223004/130001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1307223004/130001

[commit-bot: I haz the power, 2015-08-26 21:02:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-26 21:02:20]

Try jobs failed on following builders:
  Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)
  Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[bsalomon, 2015-08-26 21:09:51]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-08-26 21:10:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1307223004/150001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1307223004/150001

[commit-bot: I haz the power, 2015-08-26 21:16:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-26 21:16:18]

Dry run: This issue passed the CQ dry run.

[bsalomon, 2015-08-27 13:29:27]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2015-08-27 13:29:27]

The patchset sent to the CQ was uploaded after l-g-t-m from egdaniel@google.com
Link to the patchset: https://codereview.chromium.org/1307223004/#ps150001
(title: "fix misresolve")

[commit-bot: I haz the power, 2015-08-27 13:29:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1307223004/150001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1307223004/150001

[commit-bot: I haz the power, 2015-08-27 13:30:24]

Committed patchset #9 (id:150001) as
https://skia.googlesource.com/skia/+/ac856c97acc84dcb54d9cdb068ec8a02b8869647

[dewittj, 2015-08-27 16:48:08]

dewittj@chromium.org changed reviewers:
+ dewittj@chromium.org

[dewittj, 2015-08-27 16:48:08]

It's possible this is causing failures on GPU bots in Chromium:

https://build.chromium.org/p/chromium.gpu/builders/Win8%20Release%20%28NVIDIA...

Could you please weigh in on whether you believe that's a possibility for this
patch?

[bsalomon, 2015-08-27 16:53:40]

On 2015/08/27 16:48:08, dewittj wrote:
> It's possible this is causing failures on GPU bots in Chromium:
> 
>
https://build.chromium.org/p/chromium.gpu/builders/Win8%20Release%20%28NVIDIA...
> 
> Could you please weigh in on whether you believe that's a possibility for this
> patch?

I don't think so but I'll see if I can locally reproduce this.

[bsalomon, 2015-08-27 18:28:53]

On 2015/08/27 16:53:40, bsalomon wrote:
> On 2015/08/27 16:48:08, dewittj wrote:
> > It's possible this is causing failures on GPU bots in Chromium:
> > 
> >
>
https://build.chromium.org/p/chromium.gpu/builders/Win8%20Release%20%28NVIDIA...
> > 
> > Could you please weigh in on whether you believe that's a possibility for
this
> > patch?
> 
> I don't think so but I'll see if I can locally reproduce this.

I tried to repro locally but it passes for me. I don't suspect this change is
related to the bot failures, though.

[dewittj, 2015-08-27 18:32:24]

Thanks for looking, I will keep investigating