src/effects/SkAlphaThresholdFilter.cpp - Issue 1316513002: Change SkShader;asFragmentProcessor signature to no longer take skpaint\grcolor*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkAlphaThresholdFilter.cpp

Issue 1316513002: Change SkShader;asFragmentProcessor signature to no longer take skpaint\grcolor* (Closed) Base URL: https://skia.googlesource.com/skia.git@things

Patch Set: Address comments, fix roll(?) Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/effects/SkAlphaThresholdFilter.cpp

diff --git a/src/effects/SkAlphaThresholdFilter.cpp b/src/effects/SkAlphaThresholdFilter.cpp

index 0f96cdf59a1118ac922e35fa4ac3ee8e633efc51..b28a62bcd7aa990869f39bcd483cf0f30bd3db18 100644

--- a/src/effects/SkAlphaThresholdFilter.cpp

+++ b/src/effects/SkAlphaThresholdFilter.cpp

@@ -195,7 +195,7 @@ void GrGLAlphaThresholdEffect::onSetData(const GrGLProgramDataManager& pdman,

GR_DEFINE_FRAGMENT_PROCESSOR_TEST(AlphaThresholdEffect);

-GrFragmentProcessor* AlphaThresholdEffect::TestCreate(GrProcessorTestData* d) {

+const GrFragmentProcessor* AlphaThresholdEffect::TestCreate(GrProcessorTestData* d) {

GrTexture* bmpTex = d->fTextures[GrProcessorUnitTest::kSkiaPMTextureIdx];

GrTexture* maskTex = d->fTextures[GrProcessorUnitTest::kAlphaTextureIdx];

float innerThresh = d->fRandom->nextUScalar1();

« no previous file with comments | « src/core/SkShader.cpp ('k') | src/effects/SkArithmeticMode_gpu.cpp » ('j') | no next file with comments »