Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1468)

Issue 12880016: Add intersections for path ops (Closed)

Created:
7 years, 9 months ago by caryclark
Modified:
7 years, 8 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add intersections for path ops This CL depends on https://codereview.chromium.org/12827020/ "Add base types for path ops" The intersection of a line, quadratic, or cubic with another curve (or with itself) is found by solving the implicit equation for the curve pair. The curves are first reduced to find the simplest form that will describe the original, and to detect degenerate or special-case data like horizontal and vertical lines. For cubic self-intersection, and for a pair of cubics, the intersection is found by recursively approximating the cubic with a series of quadratics. The implicit solutions depend on the root finding contained in the DCubic and DQuad structs, and the quartic root finder included here. Committed: https://code.google.com/p/skia/source/detail?r=8552

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5696 lines, -0 lines) Patch
A src/pathops/SkDCubicIntersection.cpp View 1 1 chunk +451 lines, -0 lines 0 comments Download
A src/pathops/SkDCubicLineIntersection.cpp View 1 1 chunk +261 lines, -0 lines 0 comments Download
A src/pathops/SkDCubicToQuads.cpp View 1 chunk +190 lines, -0 lines 0 comments Download
A src/pathops/SkDLineIntersection.cpp View 1 chunk +282 lines, -0 lines 0 comments Download
A src/pathops/SkDQuadImplicit.h View 1 1 chunk +39 lines, -0 lines 0 comments Download
A src/pathops/SkDQuadImplicit.cpp View 1 1 chunk +117 lines, -0 lines 0 comments Download
A src/pathops/SkDQuadIntersection.cpp View 1 1 chunk +496 lines, -0 lines 0 comments Download
A src/pathops/SkDQuadLineIntersection.cpp View 1 1 chunk +333 lines, -0 lines 0 comments Download
A src/pathops/SkIntersections.h View 1 2 1 chunk +243 lines, -0 lines 0 comments Download
A src/pathops/SkIntersections.cpp View 1 1 chunk +261 lines, -0 lines 0 comments Download
A src/pathops/SkLineParameters.h View 1 chunk +110 lines, -0 lines 0 comments Download
A src/pathops/SkQuarticRoot.h View 1 chunk +16 lines, -0 lines 0 comments Download
A src/pathops/SkQuarticRoot.cpp View 1 1 chunk +165 lines, -0 lines 0 comments Download
A src/pathops/SkReduceOrder.h View 1 1 chunk +38 lines, -0 lines 0 comments Download
A src/pathops/SkReduceOrder.cpp View 1 1 chunk +450 lines, -0 lines 0 comments Download
A tests/PathOpsCubicIntersectionTest.cpp View 1 2 1 chunk +511 lines, -0 lines 0 comments Download
A tests/PathOpsCubicIntersectionTestData.h View 1 chunk +30 lines, -0 lines 0 comments Download
A tests/PathOpsCubicIntersectionTestData.cpp View 1 1 chunk +299 lines, -0 lines 0 comments Download
A tests/PathOpsCubicLineIntersectionTest.cpp View 1 1 chunk +61 lines, -0 lines 0 comments Download
A tests/PathOpsCubicReduceOrderTest.cpp View 1 1 chunk +226 lines, -0 lines 0 comments Download
A tests/PathOpsCubicToQuadsTest.cpp View 1 1 chunk +202 lines, -0 lines 0 comments Download
A tests/PathOpsLineIntersectionTest.cpp View 1 1 chunk +61 lines, -0 lines 0 comments Download
A tests/PathOpsLineParametetersTest.cpp View 1 1 chunk +80 lines, -0 lines 0 comments Download
A tests/PathOpsQuadIntersectionTest.cpp View 1 1 chunk +468 lines, -0 lines 0 comments Download
A tests/PathOpsQuadIntersectionTestData.h View 1 chunk +17 lines, -0 lines 0 comments Download
A tests/PathOpsQuadIntersectionTestData.cpp View 1 1 chunk +104 lines, -0 lines 0 comments Download
A tests/PathOpsQuadLineIntersectionTest.cpp View 1 1 chunk +132 lines, -0 lines 0 comments Download
A tests/PathOpsQuadParameterizationTest.cpp View 1 1 chunk +53 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
caryclark
7 years, 8 months ago (2013-04-08 11:50:10 UTC) #1
Message was sent while issue was closed.
Committed manually as r8552 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698