Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 1232333002: Fix virtual/override/final usage in the rest of Source/core/. (Closed)

Created:
5 years, 5 months ago by tkent
Modified:
5 years, 5 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, shans, tzik, dshwang, eae+blinkwatch, apavlov+blink_chromium.org, kinuko+worker_chromium.org, lushnikov+blink_chromium.org, caseq+blink_chromium.org, mvanouwerkerk+watch_chromium.org, yurys+blink_chromium.org, dglazkov+blink, blink-reviews-events_chromium.org, devtools-reviews_chromium.org, Eric Willigers, kenneth.christiansen, jfernandez, rjwright, blink-reviews-style_chromium.org, Manuel Rego, blink-reviews-paint_chromium.org, nhiroki, timvolodine, darktears, mkwst+watchlist-csp_chromium.org, mlamouri+watch-blink_chromium.org, blink-reviews-animation_chromium.org, slimming-paint-reviews_chromium.org, falken, pfeldman+blink_chromium.org, Inactive, svillar, horo+watch_chromium.org, sergeyv+blink_chromium.org, kinuko+fileapi, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix virtual/override/final usage in the rest of Source/core/. - We should specify just one of them to a function. This was done by the following command. % sed -i "" -E "s/virtual (.*) final/\1 final/g; s/virtual (.*) override/\1 override/g; s/override final/final/g" <files> - Non-base virtual destructors should have |override| keywords. This CL has no behavior changes. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198751

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+737 lines, -737 lines) Patch
M Source/core/events/AnimationEvent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/events/AnimationPlayerEvent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/events/ApplicationCacheErrorEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/events/AutocompleteErrorEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/BeforeTextInsertedEvent.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/events/BeforeUnloadEvent.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/events/ClipboardEvent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/events/CompositionEvent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/events/CustomEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/events/DOMWindowEventQueue.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/events/ErrorEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/events/EventFactory.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/EventTarget.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/events/FocusEvent.h View 5 chunks +6 lines, -6 lines 0 comments Download
M Source/core/events/GenericEventQueue.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/events/GestureEvent.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/events/HashChangeEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/KeyboardEvent.h View 3 chunks +7 lines, -7 lines 0 comments Download
M Source/core/events/MessageEvent.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/events/MouseEvent.h View 4 chunks +7 lines, -7 lines 0 comments Download
M Source/core/events/MouseRelatedEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/MutationEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/events/PageTransitionEvent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/events/PointerEvent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/events/PopStateEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/events/ProgressEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/PromiseRejectionEvent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/events/RelatedEvent.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/events/ResourceProgressEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/SecurityPolicyViolationEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/TextEvent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/events/TouchEvent.h View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/events/TransitionEvent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/events/UIEvent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/events/WheelEvent.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/fileapi/Blob.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/fileapi/Blob.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/fileapi/File.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/fileapi/FileReader.h View 2 chunks +9 lines, -9 lines 0 comments Download
M Source/core/fileapi/FileReaderLoader.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/frame/Console.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/frame/DOMTimer.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/frame/DOMWindow.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/frame/DeviceSingleWindowEventController.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/frame/FrameView.h View 15 chunks +57 lines, -57 lines 0 comments Download
M Source/core/frame/ImageBitmap.h View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/frame/LocalDOMWindow.h View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/frame/LocalDOMWindow.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/frame/LocalFrame.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/Navigator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/frame/PinchViewport.h View 2 chunks +30 lines, -30 lines 0 comments Download
M Source/core/frame/PlatformEventController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/RemoteFrame.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/RemoteFrameClient.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/RemoteFrameView.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/frame/RootFrameViewport.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/SuspendableTimer.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/imagebitmap/ImageBitmapFactories.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/inspector/AsyncCallTracker.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/AsyncCallTracker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/DOMEditor.cpp View 13 chunks +24 lines, -24 lines 0 comments Download
M Source/core/inspector/DevToolsHost.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorAnimationAgent.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorApplicationCacheAgent.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorBaseAgent.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorCSSAgent.h View 3 chunks +21 lines, -21 lines 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 8 chunks +20 lines, -20 lines 0 comments Download
M Source/core/inspector/InspectorConsoleAgent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorDOMAgent.h View 2 chunks +41 lines, -41 lines 0 comments Download
M Source/core/inspector/InspectorDOMAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorHeapProfilerAgent.h View 1 chunk +9 lines, -9 lines 0 comments Download
M Source/core/inspector/InspectorHeapProfilerAgent.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/core/inspector/InspectorHistory.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorInputAgent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorInspectorAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorLayerTreeAgent.h View 2 chunks +9 lines, -9 lines 0 comments Download
M Source/core/inspector/InspectorMemoryAgent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorPageAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorProfilerAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorResourceAgent.h View 2 chunks +12 lines, -12 lines 0 comments Download
M Source/core/inspector/InspectorResourceAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorResourceContentLoader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorRuntimeAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorState.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorStyleSheet.h View 3 chunks +7 lines, -7 lines 0 comments Download
M Source/core/inspector/InspectorStyleSheet.cpp View 1 chunk +11 lines, -11 lines 0 comments Download
M Source/core/inspector/InspectorTimelineAgent.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorTracingAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorWorkerAgent.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/inspector/InspectorWorkerAgent.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/inspector/PageConsoleAgent.h View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/core/inspector/PageRuntimeAgent.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/inspector/WorkerConsoleAgent.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/inspector/WorkerInspectorController.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/core/inspector/WorkerRuntimeAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/ChromeClient.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/CustomContextMenuProvider.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/page/EventSource.h View 3 chunks +11 lines, -11 lines 0 comments Download
M Source/core/page/Page.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/page/PageSerializer.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/core/page/PrintContextTest.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M Source/core/page/scrolling/ScrollingConstraints.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/DeprecatedPaintLayerFilterInfo.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayerScrollableArea.h View 5 chunks +46 lines, -46 lines 0 comments Download
M Source/core/paint/DisplayItemListPaintTest.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/paint/LayerClipRecorderTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/paint/LayoutObjectDrawingRecorderTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/paint/NinePieceImageGridTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/TextPainterTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/ThemePainterDefault.h View 1 chunk +14 lines, -14 lines 0 comments Download
M Source/core/paint/ThemePainterMac.h View 1 chunk +13 lines, -13 lines 0 comments Download
M Source/core/plugins/PluginView.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/plugins/testing/DictionaryPluginPlaceholder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/plugins/testing/DocumentFragmentPluginPlaceholder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/testing/InternalSettings.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/InternalSettings.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/Internals.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/NullExecutionContext.h View 2 chunks +16 lines, -16 lines 0 comments Download
M Source/core/testing/NullExecutionContext.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/timing/Performance.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/timing/PerformanceBase.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/timing/PerformanceCompositeTiming.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/timing/PerformanceMark.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/timing/PerformanceMeasure.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/timing/PerformanceRenderTiming.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/timing/PerformanceResourceTiming.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/timing/WorkerPerformance.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/AbstractWorker.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/workers/DedicatedWorkerGlobalScope.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/workers/DedicatedWorkerGlobalScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/DedicatedWorkerMessagingProxy.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/DedicatedWorkerThread.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/SharedWorker.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/workers/SharedWorkerGlobalScope.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/workers/SharedWorkerThread.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/Worker.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerConsole.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/workers/WorkerEventQueue.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/workers/WorkerEventQueue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerGlobalScope.h View 6 chunks +22 lines, -22 lines 0 comments Download
M Source/core/workers/WorkerLocation.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/workers/WorkerMessagingProxy.h View 3 chunks +8 lines, -8 lines 0 comments Download
M Source/core/workers/WorkerNavigator.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerObjectProxy.h View 2 chunks +10 lines, -10 lines 0 comments Download
M Source/core/workers/WorkerThread.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tkent
yosin@, would you review this please? This is the last one.
5 years, 5 months ago (2015-07-13 04:52:03 UTC) #2
yosin_UTC9
rs lgtm
5 years, 5 months ago (2015-07-13 05:29:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1232333002/1
5 years, 5 months ago (2015-07-13 05:30:03 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 05:59:14 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198751

Powered by Google App Engine
This is Rietveld 408576698