Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Unified Diff: Source/core/inspector/InspectorCSSAgent.cpp

Issue 1232333002: Fix virtual/override/final usage in the rest of Source/core/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/InspectorCSSAgent.h ('k') | Source/core/inspector/InspectorConsoleAgent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/InspectorCSSAgent.cpp
diff --git a/Source/core/inspector/InspectorCSSAgent.cpp b/Source/core/inspector/InspectorCSSAgent.cpp
index ba3fcb784614cebf02e2a3aede91e33037832979..bf233da5d61caf1c0b9a25a9507e3e2cef576485 100644
--- a/Source/core/inspector/InspectorCSSAgent.cpp
+++ b/Source/core/inspector/InspectorCSSAgent.cpp
@@ -153,7 +153,7 @@ class InspectorCSSAgent::InspectorResourceContentLoaderCallback final : public V
public:
InspectorResourceContentLoaderCallback(InspectorCSSAgent*, PassRefPtrWillBeRawPtr<EnableCallback>);
DECLARE_VIRTUAL_TRACE();
- virtual void handleEvent() override;
+ void handleEvent() override;
private:
RawPtrWillBeMember<InspectorCSSAgent> m_cssAgent;
@@ -193,29 +193,29 @@ public:
{
}
- virtual bool perform(ExceptionState& exceptionState) override
+ bool perform(ExceptionState& exceptionState) override
{
if (!m_styleSheet->getText(&m_oldText))
return false;
return redo(exceptionState);
}
- virtual bool undo(ExceptionState& exceptionState) override
+ bool undo(ExceptionState& exceptionState) override
{
return m_styleSheet->setText(m_oldText, exceptionState);
}
- virtual bool redo(ExceptionState& exceptionState) override
+ bool redo(ExceptionState& exceptionState) override
{
return m_styleSheet->setText(m_text, exceptionState);
}
- virtual String mergeId() override
+ String mergeId() override
{
return String::format("SetStyleSheetText %s", m_styleSheet->id().utf8().data());
}
- virtual void merge(PassRefPtrWillBeRawPtr<Action> action) override
+ void merge(PassRefPtrWillBeRawPtr<Action> action) override
{
ASSERT(action->mergeId() == mergeId());
@@ -254,12 +254,12 @@ public:
{
}
- virtual bool perform(ExceptionState& exceptionState) override
+ bool perform(ExceptionState& exceptionState) override
{
return redo(exceptionState);
}
- virtual bool undo(ExceptionState& exceptionState) override
+ bool undo(ExceptionState& exceptionState) override
{
switch (m_type) {
case SetRuleSelector:
@@ -274,7 +274,7 @@ public:
return false;
}
- virtual bool redo(ExceptionState& exceptionState) override
+ bool redo(ExceptionState& exceptionState) override
{
switch (m_type) {
case SetRuleSelector:
@@ -306,17 +306,17 @@ public:
InspectorCSSAgent::StyleSheetAction::trace(visitor);
}
- virtual String mergeId() override
+ String mergeId() override
{
return String::format("ModifyRuleAction:%d %s:%d", m_type, m_styleSheet->id().utf8().data(), m_oldRange.start);
}
- virtual bool isNoop() override
+ bool isNoop() override
{
return m_oldText == m_newText;
}
- virtual void merge(PassRefPtrWillBeRawPtr<Action> action) override
+ void merge(PassRefPtrWillBeRawPtr<Action> action) override
{
ASSERT(action->mergeId() == mergeId());
@@ -345,17 +345,17 @@ public:
{
}
- virtual bool perform(ExceptionState& exceptionState) override
+ bool perform(ExceptionState& exceptionState) override
{
return redo(exceptionState);
}
- virtual bool undo(ExceptionState& exceptionState) override
+ bool undo(ExceptionState& exceptionState) override
{
return m_styleSheet->setText(m_oldText, exceptionState);
}
- virtual bool redo(ExceptionState& exceptionState) override
+ bool redo(ExceptionState& exceptionState) override
{
if (!m_styleSheet->getText(&m_oldText))
return false;
@@ -368,12 +368,12 @@ public:
InspectorCSSAgent::StyleSheetAction::trace(visitor);
}
- virtual String mergeId() override
+ String mergeId() override
{
return String::format("SetElementStyleAction:%s", m_styleSheet->id().utf8().data());
}
- virtual void merge(PassRefPtrWillBeRawPtr<Action> action) override
+ void merge(PassRefPtrWillBeRawPtr<Action> action) override
{
ASSERT(action->mergeId() == mergeId());
@@ -398,17 +398,17 @@ public:
{
}
- virtual bool perform(ExceptionState& exceptionState) override
+ bool perform(ExceptionState& exceptionState) override
{
return redo(exceptionState);
}
- virtual bool undo(ExceptionState& exceptionState) override
+ bool undo(ExceptionState& exceptionState) override
{
return m_styleSheet->deleteRule(m_addedRange, exceptionState);
}
- virtual bool redo(ExceptionState& exceptionState) override
+ bool redo(ExceptionState& exceptionState) override
{
m_cssRule = m_styleSheet->addRule(m_ruleText, m_location, &m_addedRange, exceptionState);
if (exceptionState.hadException())
« no previous file with comments | « Source/core/inspector/InspectorCSSAgent.h ('k') | Source/core/inspector/InspectorConsoleAgent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698