Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Side by Side Diff: Source/core/plugins/testing/DictionaryPluginPlaceholder.h

Issue 1232333002: Fix virtual/override/final usage in the rest of Source/core/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef DictionaryPluginPlaceholder_h 5 #ifndef DictionaryPluginPlaceholder_h
6 #define DictionaryPluginPlaceholder_h 6 #define DictionaryPluginPlaceholder_h
7 7
8 #include "core/html/shadow/PluginPlaceholderElement.h" 8 #include "core/html/shadow/PluginPlaceholderElement.h"
9 #include "core/plugins/PluginPlaceholder.h" 9 #include "core/plugins/PluginPlaceholder.h"
10 #include "core/testing/PluginPlaceholderOptions.h" 10 #include "core/testing/PluginPlaceholderOptions.h"
(...skipping 12 matching lines...) Expand all
23 if (options.hasMessage()) 23 if (options.hasMessage())
24 placeholder->setMessage(options.message()); 24 placeholder->setMessage(options.message());
25 25
26 if (options.hasCloseable()) 26 if (options.hasCloseable())
27 placeholder->setIsCloseable(options.closeable()); 27 placeholder->setIsCloseable(options.closeable());
28 28
29 return adoptPtrWillBeNoop(new DictionaryPluginPlaceholder(placeholder.re lease())); 29 return adoptPtrWillBeNoop(new DictionaryPluginPlaceholder(placeholder.re lease()));
30 } 30 }
31 31
32 #if !ENABLE(OILPAN) 32 #if !ENABLE(OILPAN)
33 virtual ~DictionaryPluginPlaceholder() override { } 33 ~DictionaryPluginPlaceholder() override { }
34 #endif 34 #endif
35 DEFINE_INLINE_VIRTUAL_TRACE() { visitor->trace(m_pluginPlaceholderElement); } 35 DEFINE_INLINE_VIRTUAL_TRACE() { visitor->trace(m_pluginPlaceholderElement); }
36 36
37 virtual void loadIntoContainer(ContainerNode& container) override 37 void loadIntoContainer(ContainerNode& container) override
38 { 38 {
39 container.removeChildren(); 39 container.removeChildren();
40 container.appendChild(m_pluginPlaceholderElement, ASSERT_NO_EXCEPTION); 40 container.appendChild(m_pluginPlaceholderElement, ASSERT_NO_EXCEPTION);
41 } 41 }
42 42
43 private: 43 private:
44 DictionaryPluginPlaceholder(PassRefPtrWillBeRawPtr<PluginPlaceholderElement> element) : m_pluginPlaceholderElement(element) { } 44 DictionaryPluginPlaceholder(PassRefPtrWillBeRawPtr<PluginPlaceholderElement> element) : m_pluginPlaceholderElement(element) { }
45 45
46 RefPtrWillBeMember<PluginPlaceholderElement> m_pluginPlaceholderElement; 46 RefPtrWillBeMember<PluginPlaceholderElement> m_pluginPlaceholderElement;
47 }; 47 };
48 48
49 } // namespace blink 49 } // namespace blink
50 50
51 #endif // DictionaryPluginPlaceholder_h 51 #endif // DictionaryPluginPlaceholder_h
OLDNEW
« no previous file with comments | « Source/core/plugins/PluginView.h ('k') | Source/core/plugins/testing/DocumentFragmentPluginPlaceholder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698