Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(886)

Side by Side Diff: Source/core/inspector/WorkerInspectorController.cpp

Issue 1232333002: Fix virtual/override/final usage in the rest of Source/core/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/inspector/WorkerConsoleAgent.h ('k') | Source/core/inspector/WorkerRuntimeAgent.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 #include "wtf/PassOwnPtr.h" 57 #include "wtf/PassOwnPtr.h"
58 58
59 namespace blink { 59 namespace blink {
60 60
61 namespace { 61 namespace {
62 62
63 class PageInspectorProxy final : public InspectorFrontendChannel { 63 class PageInspectorProxy final : public InspectorFrontendChannel {
64 WTF_MAKE_FAST_ALLOCATED(PageInspectorProxy); 64 WTF_MAKE_FAST_ALLOCATED(PageInspectorProxy);
65 public: 65 public:
66 explicit PageInspectorProxy(WorkerGlobalScope* workerGlobalScope) : m_worker GlobalScope(workerGlobalScope) { } 66 explicit PageInspectorProxy(WorkerGlobalScope* workerGlobalScope) : m_worker GlobalScope(workerGlobalScope) { }
67 virtual ~PageInspectorProxy() { } 67 ~PageInspectorProxy() override { }
68 private: 68 private:
69 virtual void sendProtocolResponse(int callId, PassRefPtr<JSONObject> message ) override 69 void sendProtocolResponse(int callId, PassRefPtr<JSONObject> message) overri de
70 { 70 {
71 // Worker messages are wrapped, no need to handle callId. 71 // Worker messages are wrapped, no need to handle callId.
72 m_workerGlobalScope->thread()->workerReportingProxy().postMessageToPageI nspector(message->toJSONString()); 72 m_workerGlobalScope->thread()->workerReportingProxy().postMessageToPageI nspector(message->toJSONString());
73 } 73 }
74 virtual void sendProtocolNotification(PassRefPtr<JSONObject> message) overri de 74 void sendProtocolNotification(PassRefPtr<JSONObject> message) override
75 { 75 {
76 m_workerGlobalScope->thread()->workerReportingProxy().postMessageToPageI nspector(message->toJSONString()); 76 m_workerGlobalScope->thread()->workerReportingProxy().postMessageToPageI nspector(message->toJSONString());
77 } 77 }
78 virtual void flush() override { } 78 void flush() override { }
79 WorkerGlobalScope* m_workerGlobalScope; 79 WorkerGlobalScope* m_workerGlobalScope;
80 }; 80 };
81 81
82 class WorkerStateClient final : public InspectorStateClient { 82 class WorkerStateClient final : public InspectorStateClient {
83 WTF_MAKE_FAST_ALLOCATED(WorkerStateClient); 83 WTF_MAKE_FAST_ALLOCATED(WorkerStateClient);
84 public: 84 public:
85 WorkerStateClient(WorkerGlobalScope* context) { } 85 WorkerStateClient(WorkerGlobalScope* context) { }
86 virtual ~WorkerStateClient() { } 86 ~WorkerStateClient() override { }
87 87
88 private: 88 private:
89 virtual void updateInspectorStateCookie(const String& cookie) override { } 89 void updateInspectorStateCookie(const String& cookie) override { }
90 }; 90 };
91 91
92 class RunInspectorCommandsTask final : public InspectorTaskRunner::Task { 92 class RunInspectorCommandsTask final : public InspectorTaskRunner::Task {
93 public: 93 public:
94 explicit RunInspectorCommandsTask(WorkerThread* thread) 94 explicit RunInspectorCommandsTask(WorkerThread* thread)
95 : m_thread(thread) { } 95 : m_thread(thread) { }
96 virtual ~RunInspectorCommandsTask() { } 96 ~RunInspectorCommandsTask() override { }
97 virtual void run() override 97 void run() override
98 { 98 {
99 // Process all queued debugger commands. WorkerThread is certainly 99 // Process all queued debugger commands. WorkerThread is certainly
100 // alive if this task is being executed. 100 // alive if this task is being executed.
101 m_thread->willEnterNestedLoop(); 101 m_thread->willEnterNestedLoop();
102 while (MessageQueueMessageReceived == m_thread->runDebuggerTask(WorkerTh read::DontWaitForMessage)) { } 102 while (MessageQueueMessageReceived == m_thread->runDebuggerTask(WorkerTh read::DontWaitForMessage)) { }
103 m_thread->didLeaveNestedLoop(); 103 m_thread->didLeaveNestedLoop();
104 } 104 }
105 105
106 private: 106 private:
107 WorkerThread* m_thread; 107 WorkerThread* m_thread;
(...skipping 142 matching lines...) Expand 10 before | Expand all | Expand 10 after
250 visitor->trace(m_injectedScriptManager); 250 visitor->trace(m_injectedScriptManager);
251 visitor->trace(m_workerThreadDebugger); 251 visitor->trace(m_workerThreadDebugger);
252 visitor->trace(m_backendDispatcher); 252 visitor->trace(m_backendDispatcher);
253 visitor->trace(m_agents); 253 visitor->trace(m_agents);
254 visitor->trace(m_workerDebuggerAgent); 254 visitor->trace(m_workerDebuggerAgent);
255 visitor->trace(m_asyncCallTracker); 255 visitor->trace(m_asyncCallTracker);
256 visitor->trace(m_workerRuntimeAgent); 256 visitor->trace(m_workerRuntimeAgent);
257 } 257 }
258 258
259 } // namespace blink 259 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/inspector/WorkerConsoleAgent.h ('k') | Source/core/inspector/WorkerRuntimeAgent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698