Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: Source/core/frame/DOMWindow.h

Issue 1232333002: Fix virtual/override/final usage in the rest of Source/core/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/frame/DOMTimer.h ('k') | Source/core/frame/DeviceSingleWindowEventController.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef DOMWindow_h 5 #ifndef DOMWindow_h
6 #define DOMWindow_h 6 #define DOMWindow_h
7 7
8 #include "core/CoreExport.h" 8 #include "core/CoreExport.h"
9 #include "core/events/EventTarget.h" 9 #include "core/events/EventTarget.h"
10 #include "core/frame/DOMWindowBase64.h" 10 #include "core/frame/DOMWindowBase64.h"
(...skipping 25 matching lines...) Expand all
36 class SerializedScriptValue; 36 class SerializedScriptValue;
37 class Storage; 37 class Storage;
38 class StyleMedia; 38 class StyleMedia;
39 39
40 typedef HeapVector<Member<MessagePort>, 1> MessagePortArray; 40 typedef HeapVector<Member<MessagePort>, 1> MessagePortArray;
41 41
42 class CORE_EXPORT DOMWindow : public EventTargetWithInlineData, public RefCounte dWillBeNoBase<DOMWindow>, public DOMWindowBase64 { 42 class CORE_EXPORT DOMWindow : public EventTargetWithInlineData, public RefCounte dWillBeNoBase<DOMWindow>, public DOMWindowBase64 {
43 DEFINE_WRAPPERTYPEINFO(); 43 DEFINE_WRAPPERTYPEINFO();
44 REFCOUNTED_EVENT_TARGET(DOMWindow); 44 REFCOUNTED_EVENT_TARGET(DOMWindow);
45 public: 45 public:
46 virtual ~DOMWindow(); 46 ~DOMWindow() override;
47 47
48 // RefCountedWillBeGarbageCollectedFinalized overrides: 48 // RefCountedWillBeGarbageCollectedFinalized overrides:
49 DECLARE_VIRTUAL_TRACE(); 49 DECLARE_VIRTUAL_TRACE();
50 50
51 virtual bool isLocalDOMWindow() const { return false; } 51 virtual bool isLocalDOMWindow() const { return false; }
52 virtual bool isRemoteDOMWindow() const { return false; } 52 virtual bool isRemoteDOMWindow() const { return false; }
53 53
54 virtual Frame* frame() const = 0; 54 virtual Frame* frame() const = 0;
55 55
56 // ScriptWrappable overrides: 56 // ScriptWrappable overrides:
57 v8::Local<v8::Object> wrap(v8::Isolate*, v8::Local<v8::Object> creationConte xt) override final; 57 v8::Local<v8::Object> wrap(v8::Isolate*, v8::Local<v8::Object> creationConte xt) final;
58 v8::Local<v8::Object> associateWithWrapper(v8::Isolate*, const WrapperTypeIn fo*, v8::Local<v8::Object> wrapper) override final; 58 v8::Local<v8::Object> associateWithWrapper(v8::Isolate*, const WrapperTypeIn fo*, v8::Local<v8::Object> wrapper) final;
59 59
60 // EventTarget overrides: 60 // EventTarget overrides:
61 const AtomicString& interfaceName() const override; 61 const AtomicString& interfaceName() const override;
62 62
63 // DOM Level 0 63 // DOM Level 0
64 virtual Screen* screen() const = 0; 64 virtual Screen* screen() const = 0;
65 virtual History* history() const = 0; 65 virtual History* history() const = 0;
66 virtual BarProp* locationbar() const = 0; 66 virtual BarProp* locationbar() const = 0;
67 virtual BarProp* menubar() const = 0; 67 virtual BarProp* menubar() const = 0;
68 virtual BarProp* personalbar() const = 0; 68 virtual BarProp* personalbar() const = 0;
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
219 // implementation details to scripts. 219 // implementation details to scripts.
220 bool m_windowIsClosing; 220 bool m_windowIsClosing;
221 221
222 private: 222 private:
223 mutable RefPtrWillBeMember<Location> m_location; 223 mutable RefPtrWillBeMember<Location> m_location;
224 }; 224 };
225 225
226 } // namespace blink 226 } // namespace blink
227 227
228 #endif // DOMWindow_h 228 #endif // DOMWindow_h
OLDNEW
« no previous file with comments | « Source/core/frame/DOMTimer.h ('k') | Source/core/frame/DeviceSingleWindowEventController.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698