Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4914)

Unified Diff: Source/core/testing/NullExecutionContext.h

Issue 1232333002: Fix virtual/override/final usage in the rest of Source/core/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/testing/Internals.cpp ('k') | Source/core/testing/NullExecutionContext.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/testing/NullExecutionContext.h
diff --git a/Source/core/testing/NullExecutionContext.h b/Source/core/testing/NullExecutionContext.h
index 6ade2c19631ea64eb434b134e06640dbc23d085e..19ab24db1504fd863e39d92044f58ff37566ef67 100644
--- a/Source/core/testing/NullExecutionContext.h
+++ b/Source/core/testing/NullExecutionContext.h
@@ -21,26 +21,26 @@ class NullExecutionContext final : public RefCountedWillBeGarbageCollectedFinali
public:
NullExecutionContext();
- virtual void disableEval(const String&) override { }
- virtual String userAgent(const KURL&) const override { return String(); }
+ void disableEval(const String&) override { }
+ String userAgent(const KURL&) const override { return String(); }
- virtual void postTask(const WebTraceLocation&, PassOwnPtr<ExecutionContextTask>) override;
+ void postTask(const WebTraceLocation&, PassOwnPtr<ExecutionContextTask>) override;
- virtual EventTarget* errorEventTarget() override { return nullptr; }
- virtual EventQueue* eventQueue() const override { return m_queue.get(); }
+ EventTarget* errorEventTarget() override { return nullptr; }
+ EventQueue* eventQueue() const override { return m_queue.get(); }
- virtual bool tasksNeedSuspension() override { return m_tasksNeedSuspension; }
+ bool tasksNeedSuspension() override { return m_tasksNeedSuspension; }
void setTasksNeedSuspension(bool flag) { m_tasksNeedSuspension = flag; }
- virtual void reportBlockedScriptExecutionToInspector(const String& directiveText) override { }
- virtual void didUpdateSecurityOrigin() override { }
- virtual SecurityContext& securityContext() override { return *this; }
- virtual DOMTimerCoordinator* timers() override { return nullptr; }
+ void reportBlockedScriptExecutionToInspector(const String& directiveText) override { }
+ void didUpdateSecurityOrigin() override { }
+ SecurityContext& securityContext() override { return *this; }
+ DOMTimerCoordinator* timers() override { return nullptr; }
double timerAlignmentInterval() const;
- virtual void addConsoleMessage(PassRefPtrWillBeRawPtr<ConsoleMessage>) override { }
- virtual void logExceptionToConsole(const String& errorMessage, int scriptId, const String& sourceURL, int lineNumber, int columnNumber, PassRefPtrWillBeRawPtr<ScriptCallStack>) override { }
+ void addConsoleMessage(PassRefPtrWillBeRawPtr<ConsoleMessage>) override { }
+ void logExceptionToConsole(const String& errorMessage, int scriptId, const String& sourceURL, int lineNumber, int columnNumber, PassRefPtrWillBeRawPtr<ScriptCallStack>) override { }
bool isPrivilegedContext(String& errorMessage, const PrivilegeContextCheck = StandardPrivilegeCheck) const override;
@@ -54,13 +54,13 @@ public:
using RefCounted<NullExecutionContext>::ref;
using RefCounted<NullExecutionContext>::deref;
- virtual void refExecutionContext() override { ref(); }
- virtual void derefExecutionContext() override { deref(); }
+ void refExecutionContext() override { ref(); }
+ void derefExecutionContext() override { deref(); }
#endif
protected:
- virtual const KURL& virtualURL() const override { return m_dummyURL; }
- virtual KURL virtualCompleteURL(const String&) const override { return m_dummyURL; }
+ const KURL& virtualURL() const override { return m_dummyURL; }
+ KURL virtualCompleteURL(const String&) const override { return m_dummyURL; }
private:
bool m_tasksNeedSuspension;
« no previous file with comments | « Source/core/testing/Internals.cpp ('k') | Source/core/testing/NullExecutionContext.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698