Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Side by Side Diff: Source/core/page/Page.h

Issue 1232333002: Fix virtual/override/final usage in the rest of Source/core/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/page/EventSource.h ('k') | Source/core/page/PageSerializer.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. All rights reserv ed. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. All rights reserv ed.
3 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 3 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 ~PageClients(); 83 ~PageClients();
84 84
85 ChromeClient* chromeClient; 85 ChromeClient* chromeClient;
86 ContextMenuClient* contextMenuClient; 86 ContextMenuClient* contextMenuClient;
87 EditorClient* editorClient; 87 EditorClient* editorClient;
88 DragClient* dragClient; 88 DragClient* dragClient;
89 SpellCheckerClient* spellCheckerClient; 89 SpellCheckerClient* spellCheckerClient;
90 }; 90 };
91 91
92 explicit Page(PageClients&); 92 explicit Page(PageClients&);
93 virtual ~Page(); 93 ~Page() override;
94 94
95 void makeOrdinary(); 95 void makeOrdinary();
96 96
97 // This method returns all pages, incl. private ones associated with 97 // This method returns all pages, incl. private ones associated with
98 // inspector overlay, popups, SVGImage, etc. 98 // inspector overlay, popups, SVGImage, etc.
99 static HashSet<Page*>& allPages(); 99 static HashSet<Page*>& allPages();
100 // This method returns all ordinary pages. 100 // This method returns all ordinary pages.
101 static HashSet<Page*>& ordinaryPages(); 101 static HashSet<Page*>& ordinaryPages();
102 102
103 FrameHost& frameHost() const { return *m_frameHost; } 103 FrameHost& frameHost() const { return *m_frameHost; }
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
202 void willBeDestroyed(); 202 void willBeDestroyed();
203 203
204 private: 204 private:
205 void initGroup(); 205 void initGroup();
206 206
207 void setTimerAlignmentInterval(double); 207 void setTimerAlignmentInterval(double);
208 208
209 void setNeedsLayoutInAllFrames(); 209 void setNeedsLayoutInAllFrames();
210 210
211 // SettingsDelegate overrides. 211 // SettingsDelegate overrides.
212 virtual void settingsChanged(SettingsDelegate::ChangeType) override; 212 void settingsChanged(SettingsDelegate::ChangeType) override;
213 213
214 RefPtrWillBeMember<PageAnimator> m_animator; 214 RefPtrWillBeMember<PageAnimator> m_animator;
215 const OwnPtr<AutoscrollController> m_autoscrollController; 215 const OwnPtr<AutoscrollController> m_autoscrollController;
216 ChromeClient* m_chromeClient; 216 ChromeClient* m_chromeClient;
217 const OwnPtrWillBeMember<DragCaretController> m_dragCaretController; 217 const OwnPtrWillBeMember<DragCaretController> m_dragCaretController;
218 const OwnPtrWillBeMember<DragController> m_dragController; 218 const OwnPtrWillBeMember<DragController> m_dragController;
219 const OwnPtrWillBeMember<FocusController> m_focusController; 219 const OwnPtrWillBeMember<FocusController> m_focusController;
220 const OwnPtrWillBeMember<ContextMenuController> m_contextMenuController; 220 const OwnPtrWillBeMember<ContextMenuController> m_contextMenuController;
221 const OwnPtrWillBeMember<PointerLockController> m_pointerLockController; 221 const OwnPtrWillBeMember<PointerLockController> m_pointerLockController;
222 OwnPtrWillBeMember<ScrollingCoordinator> m_scrollingCoordinator; 222 OwnPtrWillBeMember<ScrollingCoordinator> m_scrollingCoordinator;
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
267 // A pointer to all the interfaces provided to in-process Frames for this Pa ge. 267 // A pointer to all the interfaces provided to in-process Frames for this Pa ge.
268 // FIXME: Most of the members of Page should move onto FrameHost. 268 // FIXME: Most of the members of Page should move onto FrameHost.
269 OwnPtrWillBeMember<FrameHost> m_frameHost; 269 OwnPtrWillBeMember<FrameHost> m_frameHost;
270 }; 270 };
271 271
272 extern template class CORE_EXTERN_TEMPLATE_EXPORT WillBeHeapSupplement<Page>; 272 extern template class CORE_EXTERN_TEMPLATE_EXPORT WillBeHeapSupplement<Page>;
273 273
274 } // namespace blink 274 } // namespace blink
275 275
276 #endif // Page_h 276 #endif // Page_h
OLDNEW
« no previous file with comments | « Source/core/page/EventSource.h ('k') | Source/core/page/PageSerializer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698